Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing staged.dependencies entry #1488

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: add missing staged.dependencies entry #1488

merged 1 commit into from
Feb 10, 2025

Conversation

walkowif
Copy link
Contributor

This addresses an error during staged.dependencies installation of teal:

File ./staged_dependencies.yaml invalid, field upstream_repos cannot be an array and must have entries repo, host

@walkowif walkowif requested a review from a team February 10, 2025 08:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

Unit Tests Summary

  1 files   27 suites   10m 39s ⏱️
274 tests 270 ✅ 4 💤 0 ❌
534 runs  530 ✅ 4 💤 0 ❌

Results for commit 12bcbba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $129.51$ $+3.60$ $0$ $0$ $0$ $0$

Results for commit 432545c

♻️ This comment has been updated with latest results.

vedhav
vedhav approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedhav vedhav merged commit e2b803e into main Feb 10, 2025
26 checks passed
@vedhav vedhav deleted the fix/add-missing-staged-dependencies-entry branch February 10, 2025 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vedhav vedhav vedhav approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkowif @vedhav @llrs-roche