Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the reporter module creation to module_teal #1468

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 29, 2025

Part of #1450 as it provides better API for people who consume teal as a shiny module.

@vedhav vedhav added the core label Jan 29, 2025
@vedhav vedhav marked this pull request as ready for review January 29, 2025 11:02
@gogonzo gogonzo self-assigned this Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Tests Summary

  1 files   28 suites   10m 33s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit eed27bd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $132.42$ $-3.54$ $+2$ $0$ $0$ $0$
shinytest2-data_summary 💚 $53.17$ $-2.42$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💚 $43.29$ $-1.66$ $0$ $0$ $0$ $0$
shinytest2-init 💚 $29.13$ $-1.18$ $0$ $0$ $0$ $0$
shinytest2-landing_popup 💚 $48.63$ $-1.99$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $37.97$ $-1.44$ $0$ $0$ $0$ $0$
shinytest2-reporter 💚 $69.61$ $-2.79$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 💚 $4.28$ $-1.02$ clicking_reset_button_restores_initial_filters_state_when_module_specific
module_teal 👶 $+0.34$ does_not_receive_report_previewer_when_none_of_the_modules_contain_reporter_argument
module_teal 👶 $+1.54$ receives_one_report_previewer_module_when_any_module_contains_reporter_argument

Results for commit 113497b

♻️ This comment has been updated with latest results.

append_reporter_module to modules.R
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vedhav vedhav merged commit 6f9f02a into main Jan 29, 2025
25 checks passed
@vedhav vedhav deleted the 1450-move-reporter-to-module_teal@main branch January 29, 2025 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants