Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always position the teal util icons in the same place #1296

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Aug 7, 2024

Have a fixed position for the icons in the top right which do not change place when the number of teal tab grows.

Before

Screenshot 2024-08-07 at 7 10 13 PM

After the changes in the PR

Screenshot 2024-08-07 at 7 09 45 PM

@vedhav vedhav added the core label Aug 7, 2024
@m7pr
Copy link
Contributor

m7pr commented Aug 7, 2024

@vedhav I think this is great, but I would ask @kumamiao for the opinion if this is acceptable change

@kumamiao
Copy link
Contributor

Looks good to me, thanks @vedhav and @m7pr for checking!

Base automatically changed from 669_insertUI@main to main August 13, 2024 03:49
@vedhav vedhav force-pushed the fix-icon-positions@669_insertUI@main branch from 5969b61 to 85e554e Compare August 13, 2024 05:51
@vedhav vedhav enabled auto-merge (squash) August 13, 2024 05:52
Copy link
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  49      11  77.55%   30, 32, 44, 55-62
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      48  55.56%   111-118, 167-177, 179, 191-212, 223, 241-244, 251-254, 257-258, 260
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             191      68  64.40%   24-52, 94, 190, 230-270
R/module_filter_data.R               52       2  96.15%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                108      11  89.81%   44-53, 67
R/module_nested_tabs.R              167      70  58.08%   33-121, 150, 200, 258, 297
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                114      21  81.58%   42-48, 88-91, 115-124
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     141      92  34.75%   43-146, 183-184, 192
R/module_transform_data.R            56      32  42.86%   17-51
R/modules.R                         162      21  87.04%   148-152, 207-210, 299-300, 352, 364-372
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 15       0  100.00%
R/teal_data_utils.R                  43       0  100.00%
R/teal_lockfile.R                    56      22  60.71%   34-38, 43-51, 72, 91, 94-102, 109
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           189       0  100.00%
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2832    1226  56.71%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 85e554e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Tests Summary

  1 files   25 suites   9m 9s ⏱️
253 tests 247 ✅ 6 💤 0 ❌
528 runs  522 ✅ 6 💤 0 ❌

Results for commit 85e554e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $43.75$ $-4.14$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💚 $38.03$ $-1.94$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💚 $42.64$ $-1.71$ $0$ $0$ $0$ $0$
shinytest2-init 💚 $27.53$ $-1.71$ $0$ $0$ $0$ $0$
shinytest2-landing_popup 💚 $44.85$ $-2.72$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $35.64$ $-2.12$ $0$ $0$ $0$ $0$
shinytest2-modules 💚 $39.06$ $-2.31$ $0$ $0$ $0$ $0$
shinytest2-reporter 💚 $71.74$ $-2.19$ $0$ $0$ $0$ $0$
shinytest2-teal_data_module 💚 $54.02$ $-1.21$ $0$ $0$ $0$ $0$
shinytest2-wunder_bar 💚 $22.17$ $-1.11$ $0$ $0$ $0$ $0$

Results for commit aa5fff4

♻️ This comment has been updated with latest results.

@vedhav vedhav requested a review from m7pr August 13, 2024 06:27
@vedhav vedhav merged commit 251eb40 into main Aug 13, 2024
25 checks passed
@vedhav vedhav deleted the fix-icon-positions@669_insertUI@main branch August 13, 2024 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants