Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow propagations #1285

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Workflow propagations #1285

merged 6 commits into from
Aug 5, 2024

Conversation

@walkowif walkowif requested a review from a team August 1, 2024 10:40
@walkowif walkowif marked this pull request as ready for review August 1, 2024 14:15
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Unit Tests Summary

  1 files   30 suites   5m 21s ⏱️
241 tests 241 ✅ 0 💤 0 ❌
507 runs  507 ✅ 0 💤 0 ❌

Results for commit 2fdbc75.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-teal_data_module 💔 $22.98$ $+2.39$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-teal_data_module 💔 $7.91$ $+2.46$ e2e_teal_data_module_will_have_a_delayed_load_of_datasets

Results for commit a6ca8cc

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             87      31  64.37%   108-115, 164-165, 167, 179-200, 231-232, 234
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              168      67  60.12%   40-122, 138, 190, 212, 234, 242, 246
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         79      36  54.43%   34-74, 106, 122
R/module_teal_with_splash.R         114      34  70.18%   66-101, 116, 137, 203-204
R/module_teal.R                     123      86  30.08%   50-119, 152-153, 159-162, 175, 189-227
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      23  85.53%   127-130, 147-151, 206-209, 291-292, 344, 356-364
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_lockfile.R                    56      22  60.71%   34-38, 43-51, 72, 91, 94-102, 109
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   324     324  0.00%    51-679
R/utils.R                           185       1  99.46%   278
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2346    1143  51.28%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2fdbc75

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru pawelru mentioned this pull request Aug 5, 2024
@walkowif walkowif merged commit 263dc1a into main Aug 5, 2024
28 of 29 checks passed
@walkowif walkowif deleted the propagations-august-2024 branch August 5, 2024 12:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
@m7pr
Copy link
Contributor

m7pr commented Aug 6, 2024

Hey @walkowif hey @pawelru I see that r-hub workflow on Scheduled Action failed for the last action https://github.com/insightsengineering/teal/actions/runs/10251244595/job/28358867629
Is that intended?

@m7pr
Copy link
Contributor

m7pr commented Aug 6, 2024

I see it fails for

✖️ No lookup refs provided. Skipping.

https://github.com/insightsengineering/r.pkg.template/blob/main/.github/workflows/rhub.yaml#L84

So I guess this is the place that needs a fix

@m7pr
Copy link
Contributor

m7pr commented Aug 6, 2024

If inputs.lookup-refs is empty - should we remove from the top of the inputs, and from the parameters of the run?

@walkowif
Copy link
Contributor Author

walkowif commented Aug 6, 2024

I'm not sure if each and every package will need the non-empty lookup-refs input.
If not, we might have to adjust the assertion in setup-r-dependencies.
If yes, we'll simply have to provide a proper lookup-refs input to each package, but the correct value for that input will have to be checked package by package.

Also: the R-hub workflows may fail and this is rather expected I think.

@m7pr
Copy link
Contributor

m7pr commented Aug 6, 2024

This was fixed by Pawel in here #1291 (review)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants