Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the integration tests by alternative #1237

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented May 29, 2024

Closes https://github.com/insightsengineering/coredev-tasks/issues/554

Changes:

  1. The container in the integration test does not seem to evaluate the JS code to check visibility when app_driver$is_visible is called with visibility_property = TRUE Bumping the chrome version to resolve this issue.
  2. Increasing the timeout threshold for wait_for_page_stability. For an unknown reason this timeout does not work in certain containers. Initial timeout (500ms) was set as a 2x of what was needed in my local machine. But looks like we need at least 800 ms to work in some loaded conditions. So, setting it to 2000 ms now.

@vedhav
Copy link
Contributor Author

vedhav commented May 29, 2024

@averissimo would appreciate your input with 1.
@kartikeyakirar added you as you were involved in 2.

Copy link
Contributor

github-actions bot commented May 29, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              161      60  62.73%   39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_teal.R                     113      79  30.09%   52-119, 150-151, 157-160, 171, 184-215
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      26  83.65%   127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   324     324  0.00%    43-671
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2257    1107  50.95%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 32c9b25

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 29, 2024

Unit Tests Summary

  1 files   30 suites   4m 26s ⏱️
240 tests 240 ✅ 0 💤 0 ❌
505 runs  505 ✅ 0 💤 0 ❌

Results for commit 32c9b25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 29, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-filter_panel 💔 $26.53$ $+6.28$ $0$ $0$ $0$ $0$
shinytest2-init 💔 $10.91$ $+1.58$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💔 $24.81$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-modules 💔 $18.64$ $+3.04$ $0$ $0$ $0$ $0$
shinytest2-reporter 💔 $34.10$ $+6.40$ $0$ $0$ $0$ $0$
shinytest2-show-rcode 💔 $4.12$ $+1.55$ $0$ $0$ $0$ $0$
shinytest2-teal_data_module 💔 $12.39$ $+12.64$ $0$ $0$ $0$ $0$
shinytest2-teal_slices 💔 $24.88$ $+28.44$ $0$ $0$ $0$ $0$
shinytest2-utils 💔 $4.01$ $+2.18$ $0$ $0$ $0$ $0$
shinytest2-wunder_bar 💔 $8.92$ $+3.14$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-filter_panel 💔 $10.08$ $+3.04$ e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules
shinytest2-filter_panel 💔 $10.75$ $+3.30$ e2e_filtering_a_module_specific_filter_is_refected_in_other_shared_module
shinytest2-init 💔 $4.14$ $+1.55$ e2e_teal_app_initializes_with_sessionInfo_modal
shinytest2-landing_popup 💔 $4.61$ $+1.33$ e2e_when_default_landing_popup_module_is_closed_it_shows_the_underlying_teal_app
shinytest2-module_bookmark_manager 💔 $6.74$ $+1.63$ bookmark_manager_button_shows_modal_with_url_containing_state_id_when_clicked
shinytest2-modules 💔 $3.92$ $+1.50$ e2e_filter_panel_only_shows_the_data_supplied_using_datanames
shinytest2-modules 💔 $3.93$ $+1.48$ e2e_filter_panel_shows_all_the_datasets_when_datanames_is_all
shinytest2-reporter 💔 $27.24$ $+6.43$ e2e_adding_a_report_card_in_a_module_adds_it_in_the_report_previewer_tab
shinytest2-show-rcode 💔 $4.12$ $+1.55$ e2e_teal_app_initializes_with_Show_R_Code_modal
shinytest2-teal_data_module 💔 $4.86$ $+5.33$ e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI
shinytest2-teal_data_module 💔 $3.02$ $+1.60$ e2e_teal_data_module_shows_validation_errors
shinytest2-teal_data_module 💔 $4.50$ $+5.71$ e2e_teal_data_module_will_have_a_delayed_load_of_datasets
shinytest2-teal_slices 💔 $9.00$ $+10.07$ e2e_teal_slices_filters_are_initialized_when_global_filters_are_created
shinytest2-teal_slices 💔 $15.88$ $+18.37$ e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created
shinytest2-utils 💔 $4.01$ $+2.18$ e2e_show_hide_hamburger_works_as_expected
shinytest2-wunder_bar 💔 $4.47$ $+1.56$ wunder_bar_srv_clicking_filter_icon_opens_filter_manager_modal
shinytest2-wunder_bar 💔 $4.45$ $+1.58$ wunder_bar_srv_clicking_snapshot_icon_opens_snapshot_manager_modal

Results for commit 0c52db3

♻️ This comment has been updated with latest results.

@vedhav vedhav enabled auto-merge (squash) May 29, 2024 13:09
@vedhav vedhav added the core label May 29, 2024
@averissimo averissimo self-assigned this May 29, 2024
@vedhav vedhav requested a review from donyunardi May 30, 2024 21:31
@vedhav vedhav assigned donyunardi and unassigned averissimo May 30, 2024
@vedhav vedhav merged commit 36c3b22 into main May 30, 2024
24 of 25 checks passed
@vedhav vedhav deleted the fix-visibility-issue@main branch May 30, 2024 22:57
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants