-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the integration tests by alternative #1237
Conversation
@averissimo would appreciate your input with 1. |
Code Coverage Summary
Diff against main
Results for commit: 32c9b25 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 30 suites 4m 26s ⏱️ Results for commit 32c9b25. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 0c52db3 ♻️ This comment has been updated with latest results. |
…lity property is changed" This reverts commit 1589a54.
Closes https://github.com/insightsengineering/coredev-tasks/issues/554
Changes:
The container in the integration test does not seem to evaluate the JS code to check visibility whenBumping the chrome version to resolve this issue.app_driver$is_visible
is called withvisibility_property = TRUE
wait_for_page_stability
. For an unknown reason this timeout does not work in certain containers. Initial timeout (500ms) was set as a 2x of what was needed in my local machine. But looks like we need at least 800 ms to work in some loaded conditions. So, setting it to 2000 ms now.