Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps {rmarkdown} minimal version #1221

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Bumps {rmarkdown} minimal version #1221

merged 8 commits into from
Jun 18, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

@averissimo averissimo marked this pull request as draft May 16, 2024 13:26
Copy link
Contributor

github-actions bot commented May 16, 2024

Unit Tests Summary

  1 files   30 suites   4m 28s ⏱️
240 tests 240 ✅ 0 💤 0 ❌
505 runs  505 ✅ 0 💤 0 ❌

Results for commit ee36d85.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 16, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_tabs_with_filters 💀 $0.95$ $-0.95$ $-8$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💔 $26.24$ $+1.39$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_nested_tabs 👶 $+0.02$ unnamed
module_tabs_with_filters 💀 $0.30$ $-0.30$ active_datanames_returns_dataname_from_active_tab_after_change
module_tabs_with_filters 💀 $0.23$ $-0.23$ active_datanames_returns_dataname_from_single_tab
module_tabs_with_filters 💀 $0.39$ $-0.39$ active_module_returns_module_specs_from_active_tab_when_filter.module_specific_FALSE
module_tabs_with_filters 💀 $0.04$ $-0.04$ srv_tabs_with_filters_throws_error_if_reporter_is_not_of_class_Reporter

Results for commit ce649f3

♻️ This comment has been updated with latest results.

@averissimo averissimo marked this pull request as ready for review May 22, 2024 22:14
@averissimo averissimo changed the title Bumps rmarkdown minimal version Bumps {rmarkdown} minimal version May 22, 2024
@averissimo averissimo marked this pull request as draft May 23, 2024 04:14
@averissimo averissimo marked this pull request as ready for review June 6, 2024 09:51
@averissimo
Copy link
Contributor Author

This passes tests: https://github.com/insightsengineering/teal/actions/runs/9398557285/job/25884138731

Only fail is release due to teal.reporter version in DESCRIPTION not being on CRAN

Copy link
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              168      67  60.12%   40-122, 138, 190, 212, 234, 242, 246
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         79      36  54.43%   34-74, 106, 122
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_teal.R                     120      84  30.00%   52-119, 150-151, 157-160, 173, 187-225
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      23  85.53%   127-130, 147-151, 206-209, 291-292, 344, 356-364
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   324     324  0.00%    43-671
R/utils.R                           185       1  99.46%   278
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2286    1119  51.05%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ee36d85

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@averissimo averissimo merged commit f2382c6 into main Jun 18, 2024
28 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch June 18, 2024 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants