Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1154 deprecation for show_rcode_modal #1217

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented May 13, 2024

Close #1154

@m7pr m7pr added the core label May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Unit Tests Summary

  1 files   30 suites   2m 51s ⏱️
240 tests 240 ✅ 0 💤 0 ❌
505 runs  505 ✅ 0 💤 0 ❌

Results for commit df992b0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think inst/js/init.js should be also removed.

@m7pr
Copy link
Contributor Author

m7pr commented May 14, 2024

For init.js I created #1218

@gogonzo
Copy link
Contributor

gogonzo commented May 14, 2024

For init.js I created #1218

Sorry my bad, init.js should be removed after hard deprecation. Not now

@m7pr
Copy link
Contributor Author

m7pr commented May 16, 2024

recheck

@m7pr
Copy link
Contributor Author

m7pr commented May 16, 2024

init.js should be removed after hard deprecation. Not now

Yes, that was clear!

@m7pr m7pr enabled auto-merge (squash) May 16, 2024 10:42
Copy link
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/TealAppDriver.R                   311     311  0.00%    43-647
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              161      60  62.73%   39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal.R                     113      79  30.09%   52-119, 150-151, 157-160, 171, 184-215
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      26  83.65%   127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2244    1094  51.25%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  --------
R/show_rcode_modal.R       +5      +5  +100.00%
TOTAL                      +5      +5  -0.11%

Results for commit: df992b0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_tabs_with_filters 👶 $+0.98$ $+8$ $0$ $0$ $0$
shinytest2-landing_popup 💔 $17.55$ $+1.07$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_nested_tabs 💀 $0.01$ $-0.01$ unnamed
module_tabs_with_filters 👶 $+0.31$ active_datanames_returns_dataname_from_active_tab_after_change
module_tabs_with_filters 👶 $+0.23$ active_datanames_returns_dataname_from_single_tab
module_tabs_with_filters 👶 $+0.40$ active_module_returns_module_specs_from_active_tab_when_filter.module_specific_FALSE
module_tabs_with_filters 👶 $+0.04$ srv_tabs_with_filters_throws_error_if_reporter_is_not_of_class_Reporter

Results for commit 87bcaff

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit b9677ff into main May 16, 2024
27 checks passed
@m7pr m7pr deleted the 1154_remove_show_rcode_modal@main branch May 16, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove teal::show_rcode_modal
2 participants