-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shinytest2 app init on R 4.4.0+ #1211
Conversation
Code Coverage Summary
Diff against main
Results for commit: 718977a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 30 suites 2m 49s ⏱️ Results for commit 718977a. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 5dc2b9c ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes the broken shinytest2 tests
The root cause is that
numeric_version
only accepts character to convert intonumeric_version
class. So typecasting of the numeric version was giving the error.Example code to test. This works in older R versions. But, in R 4.4.0 it does not work.