-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds extra parameters to methods that call TealAppDriver$set_inputs
(shinytest2)
#1175
Conversation
Code Coverage Summary
Diff against main
Results for commit: d6c7ec6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 30 suites 2m 52s ⏱️ Results for commit d6c7ec6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@averissimo has made modifications to all instances of the set_input
method used. Accordingly, could you also update the navigate_teal_tab
method and add ...
arg?
Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
@kartikeyakirar I didn't add Do you think it's worth adding on this one? |
Make sense , Leave it then |
Unit Test Performance Difference
Results for commit 1812964 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🚀
Pull Request
Fixes #1169
Changes description
TealAppDriver
methods that useAppDriver$set_inputs