-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
503 $active_module_element
method for TealAppDriver
#1156
503 $active_module_element
method for TealAppDriver
#1156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 Agreed, It would help when referencing modules inside the teal_module.
@vedhav what about one more method active_module_element_text <- function(selector) {
self$active_module_element(selector) %>% get_text()
} So instead of app$active_module_element("copy_button1") %>%
app$get_text() You just type app$active_module_element_text("copy_button1") |
CC @vedhav |
Thanks for the ping. After Paweł bought it up. It makes me wonder if we have too many of these methods which makes it hard for people to know what they do. Let's rethink about trying to simplify the usage of these methods once the dust settles and we narrow down all the methods we need. |
I don't think Pawel mentioned we have too many methods. What he mentioned was we should just organize them so it's easy to use and seek trhough in an alphabetically ordered list. If we think a method is useful and makes the code shorter I think we should go for whathever the amount of methods that makes our life easier |
We can have |
Yeah, let’s extend it to your suggestions. They’re definitely improvement. |
I found it handy to have a function like this in here #1127 (comment)
Proposing a method to exist at
TealAppDriver
directly.