503 shinytest2 fixes bug with setting numeric range

[averissimo]

Pull Request

Fixes #1151

Changes description

• shinyWidgets::numericRangeInput uses a custom handler and seems to require a js: Shiny.setInputValue call
• Change of explicit arguments in {s,g}et_active_filter_selection to type to reflect this logic and allow for further extensions.
• Removed is_numeric argument in favor of auto-detection of slice type (categorical / numerical range)
  • from {s,g}et_active_filter_selection

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      29  72.90%   50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       2  98.25%   110, 131
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         153      24  84.31%   127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R        18       0  100.00%
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   225      71  68.44%   66-77, 124-127, 135, 156-157, 165, 177-178, 200-206, 292-339, 389-397, 401, 419, 452
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1892     420  77.80%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/TealAppDriver.R      +28     +10  -0.59%
TOTAL                  +28     +10  -0.20%

Results for commit: c097183

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   26 suites   1m 30s ⏱️
226 tests 226 ✅ 0 💤 0 ❌
482 runs  482 ✅ 0 💤 0 ❌

Results for commit c097183.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-filter_panel	💚	$21.52$	$-2.25$	$0$	$0$	$0$	$0$
shinytest2-init	💚	$12.37$	$-1.82$	$0$	$0$	$0$	$0$
shinytest2-modules	💚	$20.08$	$-3.31$	$0$	$0$	$0$	$0$
shinytest2-reporter	💚	$16.50$	$-2.02$	$0$	$0$	$0$	$0$
shinytest2-teal_slices	💚	$14.21$	$-3.38$	$-1$	$0$	$0$	$0$
tdata	💚	$6.98$	$-1.50$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-teal_slices	💚	$8.77$	$-2.50$	e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created
tdata	💚	$6.61$	$-2.02$	new_tdata_accepts_reactive_and_not_reactive_MAE_and_data.frames

Results for commit f2917ba

♻️ This comment has been updated with latest results.

[vedhav]

Thanks! LGTM!