Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes redundant app from R6 class #1139

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Removes redundant app from R6 class #1139

merged 1 commit into from
Mar 8, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Mar 8, 2024 •
edited
Loading

Pull Request

Part of #503

There's no need to store "app" from super$initialize

image

@vedhav
Copy link
Contributor

vedhav commented Mar 8, 2024

Thanks @averissimo!

@vedhav vedhav merged commit d546b02 into 503-introduce-shinytest2@main Mar 8, 2024
@vedhav vedhav deleted the no_app@503-introduce-shinytest2@main branch March 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averissimo @vedhav