Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 unify html tags #1122

Merged
merged 18 commits into from
Mar 8, 2024
Merged

445 unify html tags #1122

merged 18 commits into from
Mar 8, 2024

Conversation

kartikeyakirar
Copy link
Contributor

part of insightsengineering/teal.slice#445
for teal package

Copy link
Contributor

github-actions bot commented Mar 5, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30      21  30.00%   21-33, 36-43
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 227-228, 230
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      36  66.36%   37-43, 50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154      58  62.34%   39-112, 128, 180, 202, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114       4  96.49%   110, 131, 197-198
R/module_teal.R                     106      29  72.64%   57, 68, 77, 150-151, 157, 176-207
R/modules.R                         153      27  82.35%   127-130, 147-151, 206-210, 292-293, 345, 357-365, 419-422
R/reporter_previewer_module.R        18       2  88.89%   30, 34
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/utils.R                           172       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1666     506  69.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 59981cf

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Tests Summary

  1 files   19 suites   10s ⏱️
208 tests 208 ✅ 0 💤 0 ❌
419 runs  419 ✅ 0 💤 0 ❌

Results for commit 59981cf.

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Mar 5, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! There's a problem with the CI that should be solved with my suggestion.

Tested it by removing #' @import shiny and running check to see if any of the tags$ objects is identified

@kartikeyakirar kartikeyakirar changed the title 445 unify html tags tags 445 unify html tags Mar 7, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Mar 8, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@kartikeyakirar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kartikeyakirar kartikeyakirar merged commit 0d74e49 into main Mar 8, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 445_unify_tags branch March 8, 2024 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants