-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How quickly "should" an app start? #1234
Comments
Related to #1234. Update progress bars to improve user experience. - `modules_datasets` receives optional `progress` argument that accepts a `Progress` object - `ui_nested_tabs` and `ui_tabs_with_filters` receive `progress` argument that accepts a `Progress` object - rewrote progress bar management in `srv_teal` Added a large app for testing in `__stress_test.R`, to be removed before merging. #### NOTE Once the module UI is prepared, there is still a delay before the app starts, so the progress bar can be improved further. So far I was unable to identify the reason for the delay.
As evidenced by #1236, the creating the filter panel ( |
Tip to the assignee:
|
This can be closed. We have implemented following:
|
Thank you.
You mean a singleton instead of one instance per module? |
@chlebowa Yup |
An app built with the following
data
andmodules
(no filters) takes over a minute to start*, up to a minute and a half withmodule_specific = TRUE
. The data is not particularly large but larger than the typical example data used in NEST packages. Pre-processing takes about 10 seconds. Since modules do not start until viewed, the (near) entirety of app startup taken up byteal
itself. I suppose building the filter panel is one of the more time-consuming steps.*) Measuring in a fresh session, from runnig the script that attaches all necessary packages, creates data and modules, and runs the app, until the moment the notification
Data loaded - App fully started up
appears on screen.My question is: at what point should one consider the app taking too long to start? Is there a way to improve startup time?
10 datasets of ~30 MB in total and 13 modules
``` > data ✅︎ verified teal_data object [L] Parent: Bindings: • ADRS: [L] • ADEX: [L] • ADLB: [L] • ADAE: [L] • ADVS: [L] • ADSL: [L] • ADDV: [L] • ADCM: [L] • ADTTE: [L] • ADMH: [L] ```Tagging @gogonzo for visibility.
Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: