Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hashing #126

Merged
merged 6 commits into from
Nov 11, 2022
Merged

remove hashing #126

merged 6 commits into from
Nov 11, 2022

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Nov 9, 2022

related to insightsengineering/teal#751

Remove datasets hashing and transfer it inside teal.

@mhallal1 mhallal1 added the core label Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/call_utils.R                  156       4  97.44%   142-145
R/CDISCFilteredData.R           152      28  81.58%   92, 115, 124, 128, 142-151, 255-262, 280-283, 289, 354-357
R/choices_labeled.R              49      14  71.43%   19, 30, 35, 45-50, 62, 66-70
R/eval_expr_with_msg.R           16       6  62.50%   8-13
R/filter_panel_api.R             10       0  100.00%
R/filtered_data_wrappers.R       17      17  0.00%    134-169
R/FilteredData.R                425     290  31.76%   131, 228-232, 274-288, 329-343, 601-967, 991
R/FilteredDataset.R             263      84  68.06%   103, 199, 288, 352-392, 461-467, 504-514, 683-725
R/FilterState.R                1383     706  48.95%   160, 353-354, 468, 653-667, 729-779, 920-947, 1089-1192, 1217-1223, 1397-1557, 1703, 1713-1719, 1732, 1736, 1869-1979, 2036-2042, 2055, 2187-2306, 2334-2340, 2353, 2439-2441, 2506-2667, 2696-2702, 2716
R/FilterStates.R               1417     595  58.01%   104, 123, 227, 306, 385, 436-626, 640-641, 759-795, 950-959, 1016, 1082, 1122, 1183-1188, 1323-1444, 1459, 1492, 1560-1565, 1585-1591, 1598-1603, 1610-1611, 1613, 1774-1783, 1816-1823, 1831-1838, 1866-2035, 2079, 2098-2104, 2111-2116, 2124-2125, 2127, 2175-2176, 2257-2375, 2422, 2468, 2489
R/include_css_js.R                5       5  0.00%    12-16
R/init_filitered_data.R          62       0  100.00%
R/MAEFilteredDataset.R          215      59  72.56%   25, 126, 258-334
R/Queue.R                        50      23  54.00%   22, 40-72, 96-113, 154
R/resolve_state.R                23       0  100.00%
R/utils.R                        79      15  81.01%   115-121, 133-138, 211-212
R/variable_types.R               48      33  31.25%   42-47, 57, 70-105
R/zzz.R                           6       6  0.00%    3-11
TOTAL                          4376    1885  56.92%

Diff against main

Filename               Stmts  Miss    Cover
-------------------  -------  ------  -------
R/FilteredDataset.R       -4  -       -0.48%
TOTAL                     -4  -       -0.04%

Results for commit: 970eded

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS and remove digest from desc file?

@mhallal1
Copy link
Contributor Author

NEWS and remove digest from desc file?

done both.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Unit Tests Summary

    1 files    30 suites   19s ⏱️
434 tests 434 ✔️ 0 💤 0
758 runs  758 ✔️ 0 💤 0

Results for commit b541228.

♻️ This comment has been updated with latest results.

@nikolas-burkoff nikolas-burkoff self-assigned this Nov 10, 2022
@mhallal1 mhallal1 merged commit 8bf4c29 into main Nov 11, 2022
@mhallal1 mhallal1 deleted the 751_hash_move@main branch November 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants