-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default decorator and update docs #1348
Conversation
Signed-off-by: Vedha Viyash <[email protected]>
Here is the status of decorators QC:
|
I wanted to verify the class of the output objects and here's the inspection of all the output object class:
|
Unit Tests Summary 1 files 70 suites 1h 12m 36s ⏱️ Results for commit c525a64. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit ded09df ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 suggestion, and 1 question and found 1 more module that doesn't work.
@vedhav this is excellent job.
Would you be able to create separate issues to fix each of the modules?
Raised a PR #1350 to fix the modules that need to decorate DT objects |
Raised a PR #1351 to fix the forest plot modules. Those were the last failing modules. After this all module decorators will work as expected. |
Have the same standards as tmg for the decorators
Here's the app to test decorators for all 36 modules