-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce decorators for tm_t_exposure
#1279
Introduce decorators for tm_t_exposure
#1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approved yet just to play out the discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Lluís Revilla <[email protected]>
Signed-off-by: Lluís Revilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Can you implement the comments and check if I didn't make any mistakes on creating with "suggestions"?
It helps reduce repeated and long code. Open to discuss as always, this was a sneaky change from last Friday on other PRs 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested changes look good, I'll merge them and test locally. I haven't seen any problem so merging now
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Lluís Revilla <[email protected]>
Part of insightsengineering/teal#1371
Example with decorator
Note: I placed the decorated right above some options to add additional columns and rows.
Perhaps we need to review where to place it. I would group these three options in a single panel