Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to tm_t_events_patyear to split columns by multiple (nested) variables #1203

Merged
merged 6 commits into from
Jul 27, 2024

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #1202

@edelarua edelarua added the sme label Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Unit Tests Summary

    1 files     70 suites   1h 5m 26s ⏱️
  721 tests   611 ✅ 110 💤 0 ❌
1 985 runs  1 763 ✅ 222 💤 0 ❌

Results for commit 557e8fb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💚 $127.41$ $-3.30$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💚 $703.83$ $-9.08$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $225.11$ $-5.97$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $99.29$ $-1.67$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $172.74$ $-5.62$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💚 $64.06$ $-1.28$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $99.97$ $-1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $258.98$ $-5.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $86.10$ $-1.20$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $124.38$ $-4.29$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $228.73$ $-4.07$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💚 $177.47$ $-4.80$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $81.31$ $-2.84$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $66.09$ $-2.95$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $68.31$ $-5.20$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $90.98$ $-3.17$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $73.12$ $-1.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $70.62$ $-1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💚 $58.37$ $-1.90$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $87.48$ $-1.32$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $42.58$ $+4.90$ $+2$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💚 $60.76$ $-1.63$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💚 $73.88$ $-1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💚 $57.26$ $-1.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💚 $54.63$ $-1.25$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💚 $41.68$ $-1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $125.42$ $-3.96$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💚 $64.93$ $-2.25$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $76.86$ $-2.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💚 $55.95$ $-1.58$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $88.45$ $-4.15$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $77.53$ $-3.56$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $55.89$ $-1.60$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💚 $77.55$ $-2.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💚 $63.06$ $-2.42$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_t_abnormality_by_worst_grade 💚 $12.04$ $-3.04$ e2e_tm_t_abnormality_by_worst_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_events_patyear 👶 $+6.70$ e2e_tm_t_events_patyear_Selecting_2_variables_as_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 0d8378b

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edelarua , can we add a test for this please. Thanks

@edelarua
Copy link
Contributor Author

@shajoezhu tests added :)

@shajoezhu shajoezhu enabled auto-merge (squash) July 27, 2024 00:38
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! looks good to me! thanks Em!

@shajoezhu shajoezhu merged commit a68f2b5 into main Jul 27, 2024
29 checks passed
@shajoezhu shajoezhu deleted the 1202_multi_arm_patyear@main branch July 27, 2024 00:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot split the columns by two variables in tm_t_event_patyear
2 participants