Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase rtables dep version #1195

Merged
merged 1 commit into from
Jun 13, 2024
Merged

increase rtables dep version #1195

merged 1 commit into from
Jun 13, 2024

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Jun 12, 2024

closes #1192

changes to rtables to help with "Teal app column widths"

related rtables PR

Copy link
Contributor

github-actions bot commented Jun 12, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@ayogasekaram
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Unit Tests Summary

    1 files     70 suites   1h 12m 47s ⏱️
  720 tests   610 ✅ 110 💤 0 ❌
1 983 runs  1 761 ✅ 222 💤 0 ❌

Results for commit acd36d8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💔 $858.42$ $+15.65$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $226.97$ $+5.99$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $100.61$ $+6.18$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $169.94$ $+5.11$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💔 $64.92$ $+1.65$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $102.65$ $+2.56$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $259.97$ $+9.47$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $88.43$ $+4.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $129.35$ $+8.67$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $234.95$ $+7.29$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $193.63$ $+7.38$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $79.03$ $+2.95$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $65.45$ $+2.28$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $74.30$ $+2.97$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $90.97$ $+3.22$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $75.53$ $+2.64$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $88.91$ $+1.06$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $55.16$ $+1.22$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $42.41$ $+1.11$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $132.70$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $80.61$ $+2.52$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $56.52$ $+3.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $87.77$ $+4.30$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $80.45$ $+2.91$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $55.80$ $+3.39$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💔 $38.26$ $+1.19$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $77.50$ $+6.54$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $64.81$ $+2.45$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $53.09$ $+1.64$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_g_pp_adverse_events 💔 $8.77$ $+2.99$ e2e_tm_g_pp_adverse_events_Module_initializes_in_teal_without_any_errors_and_produces_the_plot_and_table.
shinytest2-tm_t_pp_laboratory 💚 $11.47$ $-2.36$ e2e_tm_t_pp_laboratory_Deselection_of_arind_throws_validation_error.
shinytest2-tm_t_pp_laboratory 💔 $9.03$ $+2.65$ e2e_tm_t_pp_laboratory_Deselection_of_param_throws_validation_error.
shinytest2-tm_t_summary_by 💔 $8.71$ $+3.25$ e2e_tm_t_summary_by_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_summary_by 💔 $23.70$ $+1.19$ e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 9299649

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu enabled auto-merge (squash) June 13, 2024 02:20
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @ayogasekaram

@shajoezhu shajoezhu merged commit cc0b59d into main Jun 13, 2024
29 checks passed
@shajoezhu shajoezhu deleted the 1192_udpdate_desc@main branch June 13, 2024 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase rtables package version requirement
2 participants