Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release teal.logger to CRAN #51

Closed
6 tasks done
donyunardi opened this issue Aug 14, 2023 · 5 comments · Fixed by #55
Closed
6 tasks done

Release teal.logger to CRAN #51

donyunardi opened this issue Aug 14, 2023 · 5 comments · Fixed by #55
Assignees
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Aug 14, 2023

Summary

The objective is to make teal.code available on CRAN. However, a preliminary release is necessary due to ongoing updates up to this point.

Acceptance Criteria

  • Update README as directed here
  • Group vignettes in a meaningful cohorts as directed here
  • Add/Confirm the --as-cran option in CICD pipeline
  • R CMD Check passed or create new issue to fix
  • Release teal.logger (full version bump and git tag)
  • Push to CRAN
@m7pr m7pr self-assigned this Aug 29, 2023
m7pr added a commit that referenced this issue Aug 29, 2023
m7pr added a commit that referenced this issue Aug 29, 2023
m7pr added a commit that referenced this issue Aug 30, 2023
m7pr added a commit that referenced this issue Aug 30, 2023
m7pr added a commit that referenced this issue Aug 30, 2023
m7pr added a commit that referenced this issue Aug 30, 2023
m7pr added a commit that referenced this issue Aug 31, 2023
m7pr added a commit that referenced this issue Aug 31, 2023
@m7pr m7pr closed this as completed in #55 Aug 31, 2023
m7pr added a commit that referenced this issue Aug 31, 2023
Closes #51

Hey @donyunardi I did
- updated Readme with guidelines from this task
insightsengineering/coredev-tasks#462
- did not group vignettes in a meaningful structure as we only have one
vignette
- confirmed that package passes checks with `--as-cran` argument

Would you like to schedule a team meeting where we would `release and
tag` the package to GitHub all together?


```{R}
==> devtools::check(args = c('--as-cran'))

══ Documenting ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
ℹ Updating teal.logger documentation
ℹ Loading teal.logger

══ Building ════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Setting env vars:
• CFLAGS    : -Wall -pedantic -fdiagnostics-color=always
• CXXFLAGS  : -Wall -pedantic -fdiagnostics-color=always
• CXX11FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX14FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX17FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX20FLAGS: -Wall -pedantic -fdiagnostics-color=always
── R CMD build ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✔  checking for file 'C:\Rprojects\teal.logger/DESCRIPTION' (417ms)
─  preparing 'teal.logger': (496ms)
✔  checking DESCRIPTION meta-information ... 
─  installing the package to build vignettes
✔  creating vignettes (4.1s)
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
   Omitted 'LazyData' from DESCRIPTION
─  building 'teal.logger_0.1.1.9011.tar.gz'
   
══ Checking ════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Setting env vars:
• _R_CHECK_CRAN_INCOMING_REMOTE_               : FALSE
• _R_CHECK_CRAN_INCOMING_                      : FALSE
• _R_CHECK_FORCE_SUGGESTS_                     : FALSE
• _R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS_: FALSE
• NOT_CRAN                                     : true
── R CMD check ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
─  using log directory 'C:/Rprojects/teal.logger.Rcheck' (484ms)
─  using R version 4.3.0 (2023-04-21 ucrt)
─  using platform: x86_64-w64-mingw32 (64-bit)
─  R was compiled by
       gcc.exe (GCC) 12.2.0
       GNU Fortran (GCC) 12.2.0
─  running under: Windows 10 x64 (build 19044)
─  using session charset: UTF-8
─  using options '--no-manual --as-cran'
✔  checking for file 'teal.logger/DESCRIPTION'
─  this is package 'teal.logger' version '0.1.1.9011'
─  package encoding: UTF-8
✔  checking package namespace information
✔  checking package dependencies (747ms)
✔  checking if this is a source package ...
✔  checking if there is a namespace
✔  checking for executable files (529ms)
✔  checking for hidden files and directories ...
✔  checking for portable file names
✔  checking whether package 'teal.logger' can be installed (2.3s)
✔  checking installed package size ... 
✔  checking package directory
✔  checking for future file timestamps ... 
✔  checking 'build' directory
✔  checking DESCRIPTION meta-information ... 
✔  checking top-level files
✔  checking for left-over files
✔  checking index information ... 
✔  checking package subdirectories ... 
✔  checking R files for non-ASCII characters ... 
✔  checking R files for syntax errors ... 
✔  checking whether the package can be loaded (443ms)
✔  checking whether the package can be loaded with stated dependencies (448ms)
✔  checking whether the package can be unloaded cleanly (567ms)
✔  checking whether the namespace can be loaded with stated dependencies (464ms)
✔  checking whether the namespace can be unloaded cleanly (569ms)
✔  checking startup messages can be suppressed (1.1s)
✔  checking dependencies in R code (455ms)
✔  checking S3 generic/method consistency (664ms)
✔  checking replacement functions (446ms)
✔  checking foreign function calls (444ms)
✔  checking R code for possible problems (3.7s)
✔  checking Rd files (352ms)
✔  checking Rd metadata ... 
✔  checking Rd line widths ... 
✔  checking Rd cross-references ... 
✔  checking for missing documentation entries (461ms)
✔  checking for code/documentation mismatches (1.4s)
✔  checking Rd \usage sections (802ms)
✔  checking Rd contents ... 
✔  checking for unstated dependencies in examples ... 
✔  checking installed files from 'inst/doc'
✔  checking files in 'vignettes'
✔  checking examples (1.7s)
✔  checking for unstated dependencies in 'tests' ... 
─  checking tests ...
✔  Running 'testthat.R' (838ms)
✔  checking for unstated dependencies in vignettes ... 
✔  checking package vignettes in 'inst/doc' ...
✔  checking re-building of vignette outputs (1.4s)
✔  checking for non-standard things in the check directory
✔  checking for detritus in the temp directory
   
   
── R CMD check results ───────────────────────────────────────────────────────────────────────────────────── teal.logger 0.1.1.9011 ────
Duration: 25.4s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

R CMD check succeeded
```

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: Dony Unardi <[email protected]>
@m7pr m7pr reopened this Aug 31, 2023
donyunardi added a commit that referenced this issue Aug 31, 2023
@donyunardi
Copy link
Contributor Author

r-universe looks good:
image

Uploaded to CRAN and waiting for @gogonzo confirmation:
image

@gogonzo
Copy link
Contributor

gogonzo commented Sep 4, 2023

Confirmed. Let's wait for the response from the CRAN team now

@donyunardi donyunardi mentioned this issue Sep 5, 2023
11 tasks
@gogonzo
Copy link
Contributor

gogonzo commented Sep 8, 2023

on its way to CRAN.

@gogonzo gogonzo closed this as completed Sep 8, 2023
@m7pr
Copy link
Contributor

m7pr commented Sep 8, 2023 via email

@gogonzo
Copy link
Contributor

gogonzo commented Sep 8, 2023

image

averissimo added a commit that referenced this issue Sep 8, 2023
Related to #51

Closes #62


![image](https://github.com/insightsengineering/teal.logger/assets/211358/72e1be80-4fb4-4bf5-b444-e495e34ed694)

---------

Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Dony Unardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants