-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fct_relevel shim #12
fct_relevel shim #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayogasekaram thank you!!! Just a couple minor comments and we can merge 🕺🏼
remove unknown level checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ayogasekaram and @Melkiades !
@ayogasekaram can you add this update to the PRs you have open to update the standalone shims? Thank you! |
@ddsjoberg sure thing! done and ready for review :) |
add
fct_relevel
shim. closes #11Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
last-updated
field has been updated.devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
last-updated
field has been updated.pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged: