Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fct_relevel shim #12

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fct_relevel shim #12

merged 4 commits into from
Feb 27, 2025

Conversation

ayogasekaram
Copy link
Contributor

add fct_relevel shim. closes #11


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".
  • Create an issue in any repositories using {standalone} to update the standalone scripts.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayogasekaram thank you!!! Just a couple minor comments and we can merge 🕺🏼

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ayogasekaram and @Melkiades !

@ddsjoberg ddsjoberg merged commit dc35dab into main Feb 27, 2025
7 checks passed
@ddsjoberg ddsjoberg deleted the 11_fct_relevel@main branch February 27, 2025 00:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@ddsjoberg
Copy link
Collaborator

@ayogasekaram can you add this update to the PRs you have open to update the standalone shims? Thank you!

@ayogasekaram
Copy link
Contributor Author

@ddsjoberg sure thing! done and ready for review :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a forcats:: fct_relevel() shim
2 participants