update str_extract to remove stringr dep

[ayogasekaram]

closes #9

---

Pre-review Checklist (if item does not apply, mark is as complete)

• All GitHub Action workflows pass with a ✅
• PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
• If a bug was fixed, a unit test was added.
• If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
• Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
• Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

• If a bug was fixed, a unit test was added.
• If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
• Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
• Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

• All GitHub Action workflows pass with a ✅
• Approve Pull Request
• Merge the PR. Please use "Squash and merge" or "Rebase and merge".
• Create an issue in any repositories using {standalone} to update the standalone scripts.

[ddsjoberg]

Thanks @ayogasekaram !! We can leave the stringr standalone file as it is. But we do need to update lines 163 and 164 to not use str_*() functions in the install packages standalone file.

standalone/R/standalone-check_pkg_installed.R

Line 163 in 3a7ad70

compare = .data$version |> str_extract(pattern = "[>=<]+"),

[Melkiades]

Lgtm! Thanks Abi :) Could you add a small test to the stringr standalone? Just to guarantee identical ouputs (I think they do generate identical outputs but it is good to have a very small check of this)

[ayogasekaram]

Hey @Melkiades Thank you for taking a look! As for the code, this is already in place in the stringr standalone script:

https://github.com/insightsengineering/standalone/blob/3a7ad7048513a2b318d8171cef18eb75a6298315/R/standalone-stringr.R#L39C1-L45C2
https://github.com/insightsengineering/standalone/blob/3a7ad7048513a2b318d8171cef18eb75a6298315/R/standalone-stringr.R#L59C1-L61C2

and is already covered by the unit tests for this script. Is there a specific test I should add?

[ayogasekaram]

I added some anyways :) Let me know if those suffice!

[Melkiades]

I added some anyways :) Let me know if those suffice!

For me it is great! So we are 100% sure that it does the same thing. I do not know if it is fine keeping the stringr in suggestion, though. If we keep it there, I would keep the test. What do you think @ddsjoberg?

[ddsjoberg]

Awesome, thank you both!! Looks great!