Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #158 #160

Merged
merged 3 commits into from
Nov 7, 2024
Merged

close #158 #160

merged 3 commits into from
Nov 7, 2024

Conversation

shajoezhu
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Unit Tests Summary

  1 files  111 suites   2m 59s ⏱️
243 tests 213 ✅  30 💤 0 ❌
476 runs  235 ✅ 241 💤 0 ❌

Results for commit bebe20e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $13.74$ $-2.46$ $-9$ $+6$ $0$ $0$
table_aet03 💚 $4.73$ $-3.25$ $-4$ $+1$ $0$ $0$
table_aet04 💚 $11.99$ $-6.06$ $-14$ $+8$ $0$ $0$
table_pkct01 💚 $3.05$ $-1.59$ $-6$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_table 💚 $3.55$ $-2.09$ Pagination_works_for_page_types
table_aet03 💚 $4.73$ $-3.25$ AET03_variant_1_is_produced_correctly
table_pkct01 💚 $2.52$ $-1.43$ Specific_PKCT01_features_are_present

Results for commit 4058150

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Joe

@shajoezhu
Copy link
Contributor Author

this is blocked by the tern issue insightsengineering/tern#1345

@shajoezhu shajoezhu enabled auto-merge (squash) November 7, 2024 01:47
@shajoezhu shajoezhu merged commit 9eb85b5 into main Nov 7, 2024
27 of 28 checks passed
@shajoezhu shajoezhu deleted the 158_rm_stage_deps branch November 7, 2024 01:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scda.test switch from staged-dependencies to setup-r-dependencies for deps install
2 participants