Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tt_at_path and adding test coverage to error in sorting #994

Merged
merged 11 commits into from
Feb 28, 2025

Conversation

Melkiades
Copy link
Contributor

Fixes #864 but not sorting. That would need a similar handling as now in tt_at_path

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Unit Tests Summary

    1 files     28 suites   1m 44s ⏱️
  226 tests   226 ✅ 0 💤 0 ❌
1 603 runs  1 603 ✅ 0 💤 0 ❌

Results for commit 72d0f6d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Tabulation framework 💔 $18.94$ $+1.61$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Accessing and subsetting tables 👶 $+0.30$ tt_at_path_works_with_identical_split_names
sorting and pruning 👶 $+0.16$ sort_at_path_throws_an_error_when_trying_to_sort_a_table_with_identical_branching_names

Results for commit f95deac

♻️ This comment has been updated with latest results.

@Melkiades Melkiades enabled auto-merge (squash) February 7, 2025 12:17
@Melkiades
Copy link
Contributor Author

wdyt @gmbecker @edelarua @ayogasekaram ?

Copy link
Contributor

github-actions bot commented Feb 19, 2025

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               781      63  91.93%   20, 94, 97, 428, 519-520, 523, 681, 785, 877-878, 980, 983, 985-986, 1004-1007, 1027, 1142-1145, 1243-1248, 1404, 1504-1507, 1573-1576, 1612-1615, 1621-1626, 1677, 1684, 1778, 1886, 1899, 1902-1905, 1908-1911, 1938, 1970-1971
R/as_html.R                    167      25  85.03%   5-10, 77, 149-154, 159-164, 179-183, 270
R/colby_constructors.R         597      26  95.64%   81, 134, 197-200, 267-270, 411, 427, 1181, 1269, 1430, 1469, 1480, 1488, 1491, 1516, 1537, 1683, 1906-1909
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         286      22  92.31%   271, 334-337, 348-349, 351, 353, 550-554, 618-621, 684-687
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             138      31  77.54%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 295, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      15  89.05%   35, 47-61, 135-142, 178, 267, 271, 280
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1125     141  87.47%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 426, 448-451, 566, 593-594, 880-886, 1030, 1049, 1075, 1127, 1184-1185, 1222, 1257, 1295-1300, 1359, 1433-1437, 1455-1464, 1542, 1662-1665, 1690, 1712-1713, 1723, 1774, 1795-1800, 1821-1826, 1837, 1911, 1952, 2051, 2158, 2171, 2185, 2201, 2210, 2220-2224, 2274-2279, 2482, 2492-2495, 2505, 2530-2533, 2540, 2542-2545, 2667, 2701-2702, 2759, 3064, 3425, 3541, 3575-3600, 3691-3699, 3852, 3926-3932, 4144-4145, 4152, 4155-4158, 4162, 4212, 4273, 4298-4322, 4351
R/tt_afun_utils.R              417      33  92.09%   57, 178, 185, 194-208, 276, 284-285, 503, 511-514, 596-600, 620, 634-636
R/tt_as_df.R                   385      22  94.29%   90-93, 101, 138, 212-215, 366, 431, 451-454, 463, 568, 574, 606, 624, 676
R/tt_compare_tables.R           70       4  94.29%   51, 174, 246, 250
R/tt_compatibility.R           570      70  87.72%   19, 142-143, 186, 191, 319-320, 324-327, 333, 337, 521, 575-578, 615-617, 655, 688, 708, 728-731, 741-744, 789, 806-810, 816-819, 893, 920-923, 932, 994, 1002, 1013-1016, 1127, 1134, 1162-1176, 1207-1208
R/tt_dotabulation.R           1161      95  91.82%   54, 246, 251, 253, 301, 325, 329-332, 364-367, 390, 423-426, 454-457, 552, 690-694, 743, 747, 775-778, 788, 808-812, 819-822, 1082, 1086, 1117, 1220-1223, 1433-1441, 1705-1714, 1796-1799, 1810, 1815, 1820-1821, 1823, 1834, 1839, 1862, 1948-1967
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                513      37  92.79%   74, 122-131, 441, 576-579, 600-604, 749-752, 803-810, 887, 890, 908, 915, 918
R/tt_pos_and_access.R          589      41  93.04%   76, 80, 105, 166, 212-216, 258, 527, 529, 537, 543, 557, 567-570, 756, 759, 767-771, 776-779, 806, 859-860, 871, 1033-1034, 1102-1118, 1388, 1463
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    101       5  95.05%   245-248, 256
R/tt_toString.R                433      24  94.46%   123, 345, 367, 380, 390, 396, 399, 405-415, 508, 609, 811-836
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8422     799  90.51%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/tt_pos_and_access.R      +12      -1  +0.32%
TOTAL                      +12      -1  +0.03%

Results for commit: 19a823d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Melkiades Melkiades disabled auto-merge February 19, 2025 09:15
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thanks @Melkiades!

@Melkiades Melkiades enabled auto-merge (squash) February 24, 2025 15:21
@Melkiades Melkiades merged commit 0e9abc1 into main Feb 28, 2025
27 checks passed
@Melkiades Melkiades deleted the 864_fix_tt_at_path@main branch February 28, 2025 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce uniqueness of sibling names in row space
2 participants