Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer output missing horizontal line after header #572

Closed
edelarua opened this issue Mar 7, 2023 · 2 comments · Fixed by #780
Closed

Viewer output missing horizontal line after header #572

edelarua opened this issue Mar 7, 2023 · 2 comments · Fixed by #780
Assignees

Comments

@edelarua
Copy link
Contributor

edelarua commented Mar 7, 2023

As described below, the horizontal line following the header in rtable objects that is included in the ASCII output is not included in the Viewer output, or as_html output.

Observed that the ASCII output includes horizontal line displayed between header and body but using Viewer() does not display the line.

ASCII
image

Viewer()
image

Was thinking that the hline might also be missing in teal output since Viewer() is also html. this is admittedly trivial. ;-)

Originally posted by @npaszty in insightsengineering/chevron#385 (comment)

@edelarua edelarua changed the title Viewer ouput missing horizontal line after header Viewer output missing horizontal line after header Mar 7, 2023
@gmbecker
Copy link
Collaborator

gmbecker commented Mar 7, 2023

I believe the initial design intent is that the horizontal line is not needed because the header space is differentiated by color and bolding @edelarua @npaszty

That said I don't really feel strongly about this one way or another and honestly have not done much at all to the HTML rendering logic in my multiple years on the project.

@npaszty
Copy link

npaszty commented Mar 7, 2023

@gmbecker
this was feedback to dev team from a chevron template UAT.
when I described as trivial that was directed at level of importance not as to whether it is a trivial fix. ;-).
so for my part it is definitely a backlog item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants