-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding check and fixing indexing error #91
Conversation
Code Coverage Summary
Diff against main
Results for commit: 5c5f382 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@cicdguy we are still getting the (quite disruptive) false positives fromt he SuperLinter for the formatters package. |
Signed-off-by: Dinakar <[email protected]>
I think Gabe was referring to the error there was before. Thank you for fixing it ;) |
…insightsengineering/formatters into 90_fix_wrapping_header_indentation@main
…insightsengineering/formatters into 90_fix_wrapping_header_indentation@main
@cicdguy Yes please do, they're very disruptive and completely useless when trying to read the changes in the face of the mass of false positives |
@@ -212,7 +219,8 @@ MatrixPrintForm <- function(strings = NULL, | |||
prov_footer = prov_footer, | |||
col_gap = col_gap, | |||
table_inset = as.integer(table_inset), | |||
has_topleft = has_topleft | |||
has_topleft = has_topleft, | |||
indent_size = indent_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand if this is good to be added here... I do not know if this is followed by an actual indentation somewhere before. Afterwards, it is for sure reconstructed as such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still it works well now, and for the reindentation I use mat$indent_size
so I think it makes sense to have it in the object creation here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks a lot @Melkiades ! tested downstream in Chevron, it is now working.
Hi @gmbecker , hope you are well. Can you accept the changes here. The problem is now resolved. and we have several PRs downstream in Chevron is blocked by this. Thanks a lot! |
Fixes #90