-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verdepcheck fixes #267
Verdepcheck fixes #267
Conversation
Code Coverage Summary
Diff against main
Results for commit: 9713c82 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 5 suites 9s ⏱️ Results for commit 9713c82. ♻️ This comment has been updated with latest results. |
Signed-off-by: Pawel Rucki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Pawel
This aims to fix scheduled tests that are currently failing: https://github.com/insightsengineering/formatters/actions/workflows/scheduled.yaml
The rationale outlined here: insightsengineering/teal.logger#49 (comment)
I run te tests and it is passing on all variants. Ready to be reviewed and merged.