809 adjust default precision@main

[BFalquet]

close #809

update default value in egt01, tests and NEWS

thank you for the review

[github-actions]

Unit Tests Summary

  1 files   58 suites   2m 55s ⏱️
273 tests 200 ✅  73 💤 0 ❌
547 runs  357 ✅ 190 💤 0 ❌

Results for commit 874f232.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
aet04	💔	$4.26$	$+7.14$	$+8$	$-2$	$0$	$0$
chevron_tlg-methods	💔	$8.09$	$+1.49$	$+5$	$-14$	$0$	$0$
coxt01	💔	$0.62$	$+1.18$	$+6$	$-1$	$0$	$0$
coxt02	💔	$0.86$	$+1.39$	$+6$	$-1$	$0$	$0$
rspt01	💔	$3.95$	$+3.54$	$+12$	$-7$	$0$	$0$
ttet01	💔	$3.25$	$+2.46$	$+6$	$-4$	$0$	$0$
utils	💔	$0.17$	$+2.15$	$+61$	$-1$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
aet04	💔	$0.83$	$+1.25$	aet04_can_handle_NA_values
aet04	💔	$3.43$	$+5.90$	aet04_can_handle_some_NA_values
coxt01	💔	$0.59$	$+1.19$	coxt01_can_handle_some_NA_values
coxt02	💔	$0.83$	$+1.40$	coxt02_can_handle_some_NA_values
utils	👶		$+0.01$	convert_to_month_warning_messages_as_expected
utils	👶		$+0.02$	convert_to_month_work_as_expected
utils	👶		$+0.01$	do_call_errors_as_expected
utils	👶		$+0.01$	do_call_work_as_expected
utils	👶		$+0.01$	droplevels.character_works_as_expected
utils	👶		$+0.03$	execute_with_args_works_as_expected
utils	👶		$+0.01$	expand_list_works
utils	👶		$+0.01$	format_date_works_as_expected_for_Date
utils	👶		$+0.01$	format_date_works_as_expected_for_POSIXct
utils	👶		$+0.01$	get_section_div_works
utils	👶		$+0.87$	gg_list_is_deprecated
utils	👶		$+0.02$	gg_theme_chevron_works_as_expected
utils	👶		$+0.90$	grob_list_is_deprecated
utils	👶		$+0.01$	lvls.character_works_as_expected
utils	👶		$+0.01$	lvls.default_works_as_expected
utils	👶		$+0.01$	lvls.factor_works_as_expected
utils	👶		$+0.01$	modify_character_works
utils	👶		$+0.01$	modify_default_args_works_as_expected
utils	👶		$+0.01$	quote_str_works_as_expected
utils	👶		$+0.02$	set_section_div_works

Results for commit abc114b

♻️ This comment has been updated with latest results.

[BFalquet]

@cicdguy would you have time to look at the integation test ? I don't understand what is the difference between code and doc that makes the test fail. Thanks a lot.

[cicdguy]

Yeah this is strange, as they look identical.

I suspect it has something to do with the trailing newline in the docs (in egt01.Rd)

egt01_main
  Code: function(adam_db, dataset = "adeg", arm_var = "ACTARM",
                 lbl_overall = NULL, row_split_var = NULL, summaryvars
                 = c("AVAL", "CHG"), visitvar = "AVISIT", precision =
                 list(default = 0L), page_var = "PARAMCD", .stats =
                 c("n", "mean_sd", "median", "range"), skip = list(CHG
                 = "BASELINE"), ...)
  Docs: function(adam_db, dataset = "adeg", arm_var = "ACTARM",
                 lbl_overall = NULL, row_split_var = NULL, summaryvars
                 = c("AVAL", "CHG"), visitvar = "AVISIT", precision =
                 list(default = 0L), page_var = "PARAMCD", .stats =
                 c("n", "mean_sd", "median", "range"), skip = list(CHG
                 = "BASELINE"), ...)

* checking Rd \usage sections ... OK

Let me investigate further.

[cicdguy]

Perhaps relevant? r-lib/roxygen2#1484
Is adam_db an S7 class/generic?

[BFalquet]

Perhaps relevant? r-lib/roxygen2#1484 Is adam_db and S7 class/generic?

It isn't but using the same trick (arg = quote(<default value expression>)) seems to work

chevron/R/egt01.R

Line 13 in 1f182c0

egt01_main <- modify_default_args(cfbt01_main, dataset = "adeg", precision = quote(list(default = 0L)))

thank you so much @cicdguy

Note for future self: careful with documented functions generated programmatically.

[Melkiades]

Lgtm! I would avoid large snapshots as they make PR reviews problematic with my very old machine. Also, it helps to have more selective snapshot tests, so to have more clear regression tests at the end. Anyway very clear solution of the needed values ;) Thanks @BFalquet

[barnett11]

I need to confirm the PARAMCD codes for Labs, will try to confirm by tomorrow

[barnett11]

I need to confirm the PARAMCD codes for Labs, will try to confirm by tomorrow

Thanks, PARAMCD codes confirmed thank you