Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cfbt01 #777

Merged
merged 5 commits into from
Oct 11, 2024
Merged

add cfbt01 #777

merged 5 commits into from
Oct 11, 2024

Conversation

BFalquet
Copy link
Contributor

add cfbt01 to catalog (not so many options are required by the GDSR)

thank you for the review

@BFalquet BFalquet mentioned this pull request Sep 11, 2024
Open
38 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       2  96.97%   128-129
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       95      12  87.37%   86, 90-94, 126-130, 133, 175
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 29       0  100.00%
R/rmpt01.R                      59       1  98.31%   132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      178      13  92.70%   277-280, 284-287, 314, 318, 330, 332, 344
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3384      91  97.31%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1      -3  +4.43%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       -1     +11  -11.59%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +29       0  +100.00%
R/rmpt01.R                      -6     -10  +15.23%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +94     +13  -7.30%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +313     +16  -0.25%

Results for commit: ab88520

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Unit Tests Summary

  1 files   57 suites   2m 44s ⏱️
260 tests 189 ✅  71 💤 0 ❌
514 runs  333 ✅ 181 💤 0 ❌

Results for commit ab88520.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
aet04 💚 $11.47$ $-7.36$ $-8$ $+2$ $0$ $0$
chevron_tlg-methods 💚 $8.14$ $-2.95$ $-6$ $+10$ $0$ $0$
coxt01 💚 $2.03$ $-1.46$ $-6$ $+1$ $0$ $0$
coxt02 💚 $2.43$ $-1.65$ $-6$ $+1$ $0$ $0$
ext01 💚 $5.35$ $-1.02$ $-2$ $+7$ $0$ $0$
rmpt03 💚 $2.21$ $-1.04$ $-4$ $+3$ $0$ $0$
rspt01 💚 $7.86$ $-3.68$ $-12$ $+7$ $0$ $0$
ttet01 💚 $5.31$ $-2.52$ $-6$ $+4$ $0$ $0$
utils 💚 $2.50$ $-2.35$ $-61$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
aet04 💚 $2.07$ $-1.28$ aet04_can_handle_NA_values
aet04 💚 $9.40$ $-6.08$ aet04_can_handle_some_NA_values
chevron_tlg-methods 💚 $2.20$ $-1.19$ script_funs_generates_a_valid_script
coxt01 💚 $2.01$ $-1.47$ coxt01_can_handle_some_NA_values
coxt02 💚 $2.42$ $-1.66$ coxt02_can_handle_some_NA_values
utils 💀 $0.01$ $-0.01$ convert_to_month_warning_messages_as_expected
utils 💀 $0.02$ $-0.02$ convert_to_month_work_as_expected
utils 💀 $0.01$ $-0.01$ do_call_errors_as_expected
utils 💀 $0.01$ $-0.01$ do_call_work_as_expected
utils 💀 $0.01$ $-0.01$ droplevels.character_works_as_expected
utils 💀 $0.03$ $-0.03$ execute_with_args_works_as_expected
utils 💀 $0.01$ $-0.01$ expand_list_works
utils 💀 $0.01$ $-0.01$ format_date_works_as_expected_for_Date
utils 💀 $0.01$ $-0.01$ format_date_works_as_expected_for_POSIXct
utils 💀 $0.02$ $-0.02$ get_section_div_works
utils 💀 $0.95$ $-0.95$ gg_list_is_deprecated
utils 💀 $0.02$ $-0.02$ gg_theme_chevron_works_as_expected
utils 💀 $0.97$ $-0.97$ grob_list_is_deprecated
utils 💀 $0.01$ $-0.01$ lvls.character_works_as_expected
utils 💀 $0.01$ $-0.01$ lvls.default_works_as_expected
utils 💀 $0.01$ $-0.01$ lvls.factor_works_as_expected
utils 💀 $0.01$ $-0.01$ modify_character_works
utils 💀 $0.01$ $-0.01$ modify_default_args_works_as_expected
utils 💀 $0.01$ $-0.01$ quote_str_works_as_expected
utils 💀 $0.02$ $-0.02$ set_section_div_works

Results for commit eb4db8a

♻️ This comment has been updated with latest results.

@clarkliming
Copy link
Contributor

GDSR suggest to allow displaying value at visit only. is it possible in chevron?

clarkliming
clarkliming approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@BFalquet @clarkliming
Update vignettes/chevron_catalog.rmd
ab88520 
Liming's suggestion

Co-authored-by: Liming <[email protected]>
Signed-off-by: b_falquet <[email protected]>
@BFalquet BFalquet merged commit cb59c7b into main Oct 11, 2024
26 checks passed
@BFalquet BFalquet deleted the cfbt01_catalog@main branch October 11, 2024 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkliming clarkliming clarkliming approved these changes

Assignees
No one assigned
Labels
chevron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BFalquet @clarkliming