Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fstg01 and fstg02 after g_forest refactor #716

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

edelarua
Copy link
Contributor

Closes #715

Merge after chevron release and insightsengineering/tern#1158

Copy link
Contributor

github-actions bot commented Dec 14, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   72
R/aet01_aesi.R                 148       1  99.32%   211
R/aet01.R                       98       1  98.98%   168
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   114
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   10-15
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   129
R/dmt01.R                       37       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   50, 54-58
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   153
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   50
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       29       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   123-128
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       82       9  89.02%   82, 86-90, 110-111, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   87-96, 131
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   155-158
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   201-204
R/utils.R                      157      21  86.62%   142, 157, 176-178, 295-298, 302-305, 332, 336, 348, 350, 362, 379-381
R/vst02.R                       45       1  97.78%   108
R/zzz.R                          1       1  0.00%    2
TOTAL                         3246     102  96.86%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +8       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -14      +8  -9.93%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +73     +21  -13.38%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +175     +27  -0.70%

Results for commit: d67cdac

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Tests Summary

  1 files   53 suites   2m 41s ⏱️
240 tests 169 ✅  70 💤 0 ❌ 1 🔥
465 runs  298 ✅ 166 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 7811df8.

♻️ This comment has been updated with latest results.

@clarkliming
Copy link
Contributor

thank you @edelarua . Let's wait until chevron released to CRAN and then merge this

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fstg02 💔 $5.29$ $+2.58$ $-12$ $0$ $0$ $-5$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fstg02 💔 $1.20$ $+1.12$ fstg02_can_handle_customized_time_units

Results for commit 6f23e74

♻️ This comment has been updated with latest results.

@BFalquet
Copy link
Contributor

BFalquet commented Feb 1, 2024

test is failing because of a glitch in rlistings, see insightsengineering/rlistings#195

@BFalquet BFalquet requested a review from clarkliming February 1, 2024 14:31
Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving it because the remaining issue has to be fixed in rlistings, not here.

@BFalquet BFalquet merged commit 72ea464 into main Feb 5, 2024
22 of 24 checks passed
@BFalquet BFalquet deleted the 715_g_forest_updates@1109_refactor_g_forest@main branch February 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates corresponding to refactor of g_forest
3 participants