Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip vbump] prepare release #516

Merged
merged 2 commits into from
May 25, 2023
Merged

[skip vbump] prepare release #516

merged 2 commits into from
May 25, 2023

Conversation

clarkliming
Copy link
Contributor

fix check notes and update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

🧪 $Test coverage: 98.49%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ----------------
R/ael01_nollt.R                 17       1  94.12%   61
R/aet01_aesi.R                 147       1  99.32%   209
R/aet01.R                       92       1  98.91%   156
R/aet02.R                       57       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet10.R                       42       0  100.00%
R/assertions.R                  99       6  93.94%   88-93
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      109       0  100.00%
R/cmt01a.R                      76       0  100.00%
R/coxt02.R                      40       1  97.50%   114
R/dmt01.R                       26       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   48, 52-56
R/egt01.R                      102       0  100.00%
R/egt02.R                       36       0  100.00%
R/egt03.R                       61       1  98.36%   128
R/egt05_qtcat.R                 59       0  100.00%
R/ext01.R                       46       4  91.30%   110-111, 115-116
R/fstg01.R                      42       1  97.62%   95
R/kmg01.R                       28       1  96.43%   69
R/lbt01.R                      100       0  100.00%
R/lbt04.R                       69       0  100.00%
R/lbt05.R                       66       5  92.42%   125-130
R/lbt06.R                       62       3  95.16%   131-134
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       57       0  100.00%
R/mht01.R                       71       0  100.00%
R/mng01.R                      109       1  99.08%   128
R/pdt01.R                       59       0  100.00%
R/pdt02.R                       66       0  100.00%
R/rmpt01.R                      46       2  95.65%   90, 110
R/rspt01.R                      73       3  95.89%   158-161
R/rtables_utils.R              161       2  98.76%   41, 98
R/standard_rules.R              11       0  100.00%
R/ttet01.R                     126       3  97.62%   228-231
R/utils.R                       50       0  100.00%
R/vst01.R                      105       0  100.00%
R/vst02.R                       46       1  97.83%   106
TOTAL                         2844      43  98.49%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5eb26c0aa07732dcc060d84904aa71836cc32fb9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Unit Tests Summary

    1 files    43 suites   2m 35s ⏱️
192 tests 145 ✔️   47 💤 0
398 runs  286 ✔️ 112 💤 0

Results for commit 97270a7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. For the note relative to the size of the package, I wonder if this is ok or if we should trim syn_data

@@ -1,7 +1,7 @@
Type: Package
Package: chevron
Title: Standard TLGs for Clinical Trials Reporting
Version: 0.1.5
Version: 0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly version 0.2 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be. we are introducing many breaking changes in chevron so it is not good to continue with 0.1.x

@clarkliming
Copy link
Contributor Author

trimming of data can happen in next increment

@clarkliming
Copy link
Contributor Author

autovalidator passes. we can add back the remotes field and re-tag

@BFalquet BFalquet merged commit f77f63b into main May 25, 2023
@BFalquet BFalquet deleted the prepare_release@main branch May 25, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants