Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #511

Merged
merged 4 commits into from
May 23, 2023
Merged

bug fix #511

merged 4 commits into from
May 23, 2023

Conversation

clarkliming
Copy link
Contributor

close #461
close #483
close #488

@clarkliming clarkliming requested a review from BFalquet May 23, 2023 05:35
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Unit Tests Summary

    1 files    41 suites   2m 35s ⏱️
186 tests 139 ✔️   47 💤 0
387 runs  279 ✔️ 108 💤 0

Results for commit c871144.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

🧪 $Test coverage: 98.53%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ----------------
R/ael01_nollt.R                 17       1  94.12%   61
R/aet01_aesi.R                 147       1  99.32%   209
R/aet01.R                       92       1  98.91%   156
R/aet02.R                       57       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet10.R                       42       0  100.00%
R/assertions.R                  99       6  93.94%   88-93
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      109       0  100.00%
R/cmt01a.R                      76       0  100.00%
R/coxt02.R                      40       1  97.50%   114
R/dmt01.R                       26       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   48, 52-56
R/egt01.R                      102       0  100.00%
R/egt02.R                       36       0  100.00%
R/egt03.R                       61       1  98.36%   128
R/egt05_qtcat.R                 59       0  100.00%
R/ext01.R                       46       4  91.30%   110-111, 115-116
R/fstg01.R                      42       1  97.62%   95
R/kmg01.R                       28       1  96.43%   69
R/lbt01.R                      100       0  100.00%
R/lbt04.R                       69       0  100.00%
R/lbt05.R                       66       5  92.42%   125-130
R/lbt06.R                       62       3  95.16%   131-134
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       57       0  100.00%
R/mht01.R                       71       0  100.00%
R/mng01.R                      109       1  99.08%   128
R/pdt01.R                       59       0  100.00%
R/pdt02.R                       66       0  100.00%
R/rmpt01.R                      46       2  95.65%   90, 110
R/rspt01.R                      74       3  95.95%   160-163
R/rtables_utils.R              161       2  98.76%   41, 98
R/standard_rules.R              11       0  100.00%
R/utils.R                       50       0  100.00%
R/vst01.R                      105       0  100.00%
R/vst02.R                       46       1  97.83%   106
TOTAL                         2719      40  98.53%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/egt02.R        +1       0  +100.00%
R/lbt06.R         0     -37  +59.68%
TOTAL            +1     -37  +1.36%

Results for commit: 0d50b996d5063b7c5a99c1ad5ff4d7a2c56b8e62

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, please see small comments inside

Co-authored-by: b_falquet <[email protected]>
Signed-off-by: Liming <[email protected]>
@clarkliming clarkliming merged commit e496f9d into main May 23, 2023
@clarkliming clarkliming deleted the 488_remove_unit@main branch May 23, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LBT07_1 column improvment without units BUG: Egt02_1 use assertInt to replace assertIntegerish
2 participants