Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template fstg01 #504

Merged
merged 89 commits into from
May 22, 2023
Merged

template fstg01 #504

merged 89 commits into from
May 22, 2023

Conversation

duanx9
Copy link
Contributor

@duanx9 duanx9 commented May 17, 2023

Close #380

  • Adapt new graph style and leverage utility functions
  • Add unit tests
  • Argument scope refinement

@duanx9 duanx9 marked this pull request as ready for review May 18, 2023 07:04
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

Unit Tests Summary

    1 files    40 suites   1m 59s ⏱️
170 tests 127 ✔️   43 💤 0
336 runs  232 ✔️ 104 💤 0

Results for commit 61d0e91.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

🧪 $Test coverage: 96.35%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------
R/ael01_nollt.R                 17       1  94.12%   61
R/aet01_aesi.R                 147       1  99.32%   209
R/aet01.R                       92       1  98.91%   156
R/aet02.R                       57       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet10.R                       42       0  100.00%
R/assertions.R                 145      22  84.83%   41-42, 181-186, 306-312, 329-335
R/checks.R                      20       6  70.00%   70-76
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      112      12  89.29%   378-450
R/cmt01a.R                      76       9  88.16%   80-83, 141-145
R/coxt02.R                      40       1  97.50%   112
R/dmt01.R                       26       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   48, 52-56
R/egt01.R                      102       0  100.00%
R/egt02.R                       35       0  100.00%
R/egt03.R                       61       1  98.36%   128
R/egt05_qtcat.R                 59       0  100.00%
R/ext01.R                       46       4  91.30%   110-111, 115-116
R/fstg01.R                      42       1  97.62%   95
R/kmg01.R                       28       1  96.43%   69
R/lbt01.R                      100       0  100.00%
R/lbt04.R                       69       0  100.00%
R/lbt05.R                       66       5  92.42%   126-131
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       57       0  100.00%
R/mht01.R                       71       0  100.00%
R/mng01.R                      109      12  88.99%   128, 132-135, 144-152, 192
R/pdt01.R                       59       0  100.00%
R/pdt02.R                       66       0  100.00%
R/rmpt01.R                      46       2  95.65%   90, 111
R/rspt01.R                      74       3  95.95%   160-163
R/rtables_utils.R              161       2  98.76%   41, 98
R/standard_rules.R              11       0  100.00%
R/utils.R                       50       8  84.00%   136, 149-153, 162-170
R/vst01.R                      105       0  100.00%
R/vst02.R                       46       1  97.83%   106
TOTAL                         2711      99  96.35%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/fstg01.R      +42      +1  +97.62%
TOTAL           +42      +1  +0.02%

Results for commit: 67ca24ecd531770b1114693919ca22cdc222c77f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@duanx9 duanx9 requested a review from clarkliming May 18, 2023 08:25
@duanx9
Copy link
Contributor Author

duanx9 commented May 18, 2023

*correction: subgroups can handle missing values.

@duanx9 duanx9 self-assigned this May 18, 2023
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, it looks good. minor comment on the docs, and we can open review task after merge

@duanx9 duanx9 merged commit a14c0fb into main May 22, 2023
@duanx9 duanx9 deleted the 380_fstg01@main branch May 22, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSTG01 [spec added]
3 participants