Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49 Fix the decorator #50

Merged
merged 11 commits into from
Sep 28, 2021
Merged

49 Fix the decorator #50

merged 11 commits into from
Sep 28, 2021

Conversation

BFalquet
Copy link
Contributor

close #49

allow the display of a title and decorator even when overall column is not present. Thank you for the review.

@BFalquet BFalquet requested a review from waddella September 24, 2021 14:46
add_overall_col(label = lbl_overall) %>%
add_colcounts()

if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall)
if (!identical(lbl_overall, ""))
layout_table <- layout_table %>% add_overall_col(label = lbl_overall)

add_overall_col(label = lbl_overall) %>%
add_colcounts()

if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a lintr task

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #62

@BFalquet BFalquet merged commit f6819d9 into main Sep 28, 2021
@BFalquet BFalquet deleted the 49_fix-the-decorator@main branch September 28, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the decorator
2 participants