-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
49 Fix the decorator #50
Conversation
add_overall_col(label = lbl_overall) %>% | ||
add_colcounts() | ||
|
||
if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall) | |
if (!identical(lbl_overall, "")) | |
layout_table <- layout_table %>% add_overall_col(label = lbl_overall) |
add_overall_col(label = lbl_overall) %>% | ||
add_colcounts() | ||
|
||
if (!identical(lbl_overall, "")) layout_table <- layout_table %>% add_overall_col(label = lbl_overall) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a lintr task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #62
close #49
allow the display of a title and decorator even when overall column is not present. Thank you for the review.