Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update character to list and remove remotes field #465

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

clarkliming
Copy link
Contributor

close #464

@clarkliming clarkliming requested a review from BFalquet March 27, 2023 15:04
@github-actions
Copy link
Contributor

🧪 $Test coverage: 97.17%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------
R/aet01_aesi.R                 189       7  96.30%   40, 42-46, 282
R/aet01.R                      349       5  98.57%   41, 257, 332, 338, 569
R/aet02.R                      225       1  99.56%   484
R/aet03.R                       83       0  100.00%
R/aet04.R                      107       2  98.13%   169, 186
R/assertions.R                  64       0  100.00%
R/checks.R                      20       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      136      12  91.18%   410-482
R/cmt01a.R                     189       0  100.00%
R/cmt02_pt.R                    51       0  100.00%
R/dmt01.R                       32       0  100.00%
R/dst01.R                      292       0  100.00%
R/dtht01.R                      96       0  100.00%
R/egt01.R                       46       0  100.00%
R/egt02.R                       58       0  100.00%
R/egt03.R                      134       3  97.76%   118, 162, 319
R/egt05_qtcat.R                 56       0  100.00%
R/ext01.R                       81       8  90.12%   236-239, 243-246
R/lbt01.R                       95       0  100.00%
R/lbt04.R                       51       0  100.00%
R/lbt05.R                       71       5  92.96%   152-157
R/lbt07.R                       91       1  98.90%   171
R/lbt14.R                      202      32  84.16%   54, 56, 107-110, 112-120, 150, 262, 264, 315-318, 320-328, 358
R/mht01.R                       71       2  97.18%   33-34
R/mng01.R                       97      12  87.63%   114, 118-121, 130-138, 182
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       67       0  100.00%
R/utils.R                       72       0  100.00%
R/vst01.R                       48       0  100.00%
R/vst02.R                       98       2  97.96%   110, 242
TOTAL                         3252      92  97.17%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  +2      -1  +0.57%
R/aet01.R                      +21      -1  +0.40%
R/aet02.R                       +6      -1  +0.47%
R/aet04.R                       +2       0  +0.04%
R/chevron_tlg-S4methods.R       +5      -1  +1.10%
R/dmt01.R                       -8       0  +100.00%
R/dst01.R                       +9       0  +100.00%
R/dtht01.R                      -6       0  +100.00%
R/egt01.R                       +1       0  +100.00%
R/egt03.R                       +4       0  +0.07%
R/egt05_qtcat.R                 +1       0  +100.00%
R/ext01.R                       +2       0  +0.25%
R/lbt01.R                       +1       0  +100.00%
R/lbt04.R                        0      -1  +1.96%
R/lbt05.R                       -4      -5  +6.29%
R/lbt07.R                       +5       0  +0.06%
R/lbt14.R                       +2      -2  +1.16%
R/mng01.R                       +4       0  +0.53%
R/pdt01.R                        0     -37  +61.67%
R/utils.R                     -116    -130  +69.15%
R/vst01.R                       +1       0  +100.00%
R/vst02.R                       -2      -1  +0.96%
TOTAL                          -70    -180  +5.39%

Results for commit: 4d03af00755b8c016ab110aaf16a2d36ae1cc83f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    30 suites   2m 23s ⏱️
162 tests 114 ✔️   48 💤 0
322 runs  217 ✔️ 105 💤 0

Results for commit 76339be.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see PR in citril to remove req_table arguments

@BFalquet BFalquet self-requested a review March 27, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove remotes and potential updates to make a new release
2 participants