Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

175 decorate export generic@main #423

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Conversation

clarkliming
Copy link
Contributor

@clarkliming clarkliming commented Mar 8, 2023

support the decoration, including 'gg_list' and 'grob_list' object. They are needed because a simple "list" we could not dispatch the method well (it could contain different classed inside we will pay more to check the classes)

@clarkliming clarkliming marked this pull request as ready for review March 10, 2023 06:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

🧪 $Test coverage: 91.57%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/aet01_aesi.R                 187       8  95.72%   37, 39-43, 266, 278
R/aet01.R                      328       6  98.17%   36, 238, 250, 312, 318, 544
R/aet02.R                      219       2  99.09%   129, 469
R/aet03.R                       81       0  100.00%
R/aet04.R                      105       2  98.10%   162, 167
R/assertions.R                  64       0  100.00%
R/checks.R                      20       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      131      13  90.08%   43, 408-480
R/cmt01a.R                     189       0  100.00%
R/cmt02_pt.R                    51       0  100.00%
R/dmt01.R                       31       0  100.00%
R/dst01.R                      292       0  100.00%
R/dtht01.R                      96       0  100.00%
R/egt01.R                       45       0  100.00%
R/egt02.R                       58       0  100.00%
R/egt03.R                      130       3  97.69%   114, 158, 311
R/egt05_qtcat.R                 55       0  100.00%
R/ext01.R                       79       8  89.87%   230-233, 237-240
R/gen_args.R                     1       1  0.00%    29
R/lbt01.R                       94       0  100.00%
R/lbt04.R                       51       1  98.04%   120
R/lbt05.R                       71       6  91.55%   139, 151-156
R/lbt07.R                       86       1  98.84%   164
R/lbt14.R                      202      34  83.17%   53, 55, 105-108, 110-118, 148, 177, 259, 261, 311-314, 316-324, 354, 383
R/mht01.R                       71       2  97.18%   32-33
R/mng01.R                       94      12  87.23%   110, 114-117, 126-134, 178
R/pdt01.R                       60      37  38.33%   34-50, 102-142
R/pdt02.R                       67       0  100.00%
R/utils.R                      206     142  31.07%   70, 83-241, 402, 415-420
R/vst01.R                       47       0  100.00%
R/vst02.R                      100       3  97.00%   40, 114, 245
TOTAL                         3332     281  91.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/aet03.R        -2       0  +100.00%
R/dmt01.R        -9       0  +100.00%
R/dst01.R        +9       0  +100.00%
R/dtht01.R       -6       0  +100.00%
R/lbt05.R        -4      -4  +4.88%
R/lbt14.R        +2       0  +0.17%
R/mng01.R        +1       0  +0.14%
R/utils.R       +18     +12  +0.22%
TOTAL            +9      +8  -0.22%

Results for commit: b3c653796fff90425f6e77e1622db7eb1b8fc399

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Unit Tests Summary

    1 files    26 suites   1m 50s ⏱️
129 tests   91 ✔️ 38 💤 0
277 runs  186 ✔️ 91 💤 0

Results for commit 185e44d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you for the enhancement, look good to me. Please add to pkgdown or make it internal.

clarkliming and others added 3 commits March 10, 2023 19:06
Co-authored-by: b_falquet <[email protected]>
Signed-off-by: Liming <[email protected]>
Co-authored-by: b_falquet <[email protected]>
Signed-off-by: Liming <[email protected]>
@clarkliming clarkliming merged commit 11b3ed4 into main Mar 10, 2023
@clarkliming clarkliming deleted the 175_decorate_export_generic@main branch March 10, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants