Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update args in lyt and main #412

Merged
merged 7 commits into from
Mar 10, 2023
Merged

update args in lyt and main #412

merged 7 commits into from
Mar 10, 2023

Conversation

duanx9
Copy link
Contributor

@duanx9 duanx9 commented Mar 1, 2023

Close #388

@clarkliming
Copy link
Contributor

thank you @duanx9 this is very good. harmonizing this will help us in the script generation

@duanx9 duanx9 marked this pull request as ready for review March 9, 2023 01:52
@duanx9 duanx9 requested a review from clarkliming March 9, 2023 01:52
@duanx9 duanx9 self-assigned this Mar 9, 2023
@duanx9 duanx9 added the chevron label Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Unit Tests Summary

    1 files    26 suites   2m 39s ⏱️
129 tests   91 ✔️ 38 💤 0
277 runs  186 ✔️ 91 💤 0

Results for commit fd2f7c8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
cmt01a 💚 $5.31$ $-1.18$ $0$ $0$ $0$ $0$
default_tlg 💚 $53.02$ $-11.49$ $0$ $0$ $0$ $0$
dmt01 💚 $5.29$ $-1.35$ $0$ $0$ $0$ $0$
dst01 💚 $9.80$ $-2.15$ $0$ $0$ $0$ $0$
empty_report 💚 $13.73$ $-3.21$ $0$ $0$ $0$ $0$
lbt14 💚 $9.76$ $-2.19$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
default_tlg 💚 $13.30$ $-2.77$ vst01_1_functions_with_default_argument_value_return_expected_result_with_test_data
empty_report 💚 $13.73$ $-3.21$ tlg_functions_return_null_reports_when_domain_table_is_empty

Results for commit 2ace5571823cc03a6e4166ff2dfae77a38615a22

♻️ This comment has been updated with latest results.

@duanx9 duanx9 marked this pull request as draft March 9, 2023 02:14
@duanx9 duanx9 marked this pull request as ready for review March 9, 2023 06:16
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

🧪 $Test coverage: 91.59%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/aet01_aesi.R                 187       8  95.72%   37, 39-43, 266, 278
R/aet01.R                      328       6  98.17%   36, 238, 250, 312, 318, 544
R/aet02.R                      225       2  99.11%   133, 481
R/aet03.R                       83       0  100.00%
R/aet04.R                      107       2  98.13%   166, 171
R/assertions.R                  64       0  100.00%
R/checks.R                      20       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      131      13  90.08%   43, 408-480
R/cmt01a.R                     189       0  100.00%
R/cmt02_pt.R                    51       0  100.00%
R/dmt01.R                       31       0  100.00%
R/dst01.R                      292       0  100.00%
R/dtht01.R                      96       0  100.00%
R/egt01.R                       45       0  100.00%
R/egt02.R                       58       0  100.00%
R/egt03.R                      130       3  97.69%   114, 158, 311
R/egt05_qtcat.R                 55       0  100.00%
R/ext01.R                       79       8  89.87%   230-233, 237-240
R/gen_args.R                     1       1  0.00%    29
R/lbt01.R                       94       0  100.00%
R/lbt04.R                       51       1  98.04%   120
R/lbt05.R                       71       6  91.55%   139, 151-156
R/lbt07.R                       86       1  98.84%   164
R/lbt14.R                      202      34  83.17%   53, 55, 105-108, 110-118, 148, 177, 259, 261, 311-314, 316-324, 354, 383
R/mht01.R                       71       2  97.18%   32-33
R/mng01.R                       94      12  87.23%   110, 114-117, 126-134, 178
R/pdt01.R                       60      37  38.33%   34-50, 102-142
R/pdt02.R                       67       0  100.00%
R/utils.R                      206     142  31.07%   70, 83-241, 402, 415-420
R/vst01.R                       47       0  100.00%
R/vst02.R                      100       3  97.00%   40, 114, 245
TOTAL                         3342     281  91.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/aet02.R        +6       0  +0.02%
R/aet04.R        +2       0  +0.04%
R/dmt01.R        -9       0  +100.00%
R/dst01.R        +9       0  +100.00%
R/dtht01.R       -6       0  +100.00%
R/lbt05.R        -4      -4  +4.88%
R/lbt14.R        +2       0  +0.17%
R/mng01.R        +1       0  +0.14%
R/utils.R       +18     +12  +0.22%
TOTAL           +19      +8  -0.19%

Results for commit: 850683ed0a34461e6a2a1b9575d17b0bc37aeabf

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me , thank you for the tedious work.

@duanx9 duanx9 merged commit bfde393 into main Mar 10, 2023
@duanx9 duanx9 deleted the 388_update_args_scope@main branch March 10, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly list lyt arg in main and refine scope of args in layouts
3 participants