-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt to reformat function in dunlin #409
Conversation
🧪 Code Coverage Summary
Diff against main
Results for commit: d6e6eb8858bb057a15305c686173c424d5a6558f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Additional test case details
Results for commit d6e6eb8858bb057a15305c686173c424d5a6558f ♻️ This comment has been updated with latest results. |
@@ -96,14 +96,14 @@ dmt01_1_pre <- function(adam_db) { | |||
|
|||
new_format <- list( | |||
adsl = list( | |||
SEX = list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should contain this rule to change the display of SEX. this preprocessing is now displayed for users when they use script based approach, but don't know if it is so clear. @barnett11 what do you think?
R/lbt05.R
Outdated
@@ -114,12 +113,12 @@ lbt05_1_pre <- function(adam_db, arm_var = "ACTARM") { | |||
|
|||
new_format <- list( | |||
adlb = list( | |||
AVALCAT1 = list("<Missing>" = c("", NA, "<Missing>", "No Coding Available")), | |||
abn_dir = list("<Missing>" = c("", NA, "<Missing>", "No Coding Available")) | |||
AVALCAT1 = rule("<Missing>" = c("", NA, "<Missing>", "No Coding Available")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, we can add a missing
rule to facilitate this, and remove the redudant rule definitions. anyway rule are desinged to be resued right
@@ -482,15 +482,15 @@ aet01_2_pre <- function(adam_db) { | |||
) %>% | |||
dm_update_zoomed() | |||
|
|||
missing_list <- list("<Missing>" = c("", NA)) | |||
missing_rule <- rule("<Missing>" = c("", NA)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether these rules should be some static object, instead of being defined on the fly? (but anyway these rules are super fast probably we keep as is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor comment on whether we should store these rules, like missing_rule = rule("<Missing>" = c("", NA_character))
somewhere but it should be fine for now
or open a issue for further discussion @BFalquet
adapt chevron preprocessing and tests to the new
reformat
method from dunlin.Sister PR to the
dunlin
PR: insightsengineering/dunlin#58 please merge at the same time.thank you for the review