Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete refactor of postprocess #316

Merged
merged 3 commits into from
Nov 10, 2022
Merged

complete refactor of postprocess #316

merged 3 commits into from
Nov 10, 2022

Conversation

clarkliming
Copy link
Contributor

@clarkliming clarkliming commented Nov 9, 2022

close #314

move prune/sort/null_report to post processings

other things changed:

  1. move scda to imports (avoid errors when user try to run examples without scda)
  2. create data with syn_test_data to increase the speed
  3. add helper script for testthat to avoid repeated call of syn_test_data()
  4. create null_report object and export it
  5. put "no observations.." in content instead of header

decorations, should also go into "post-processings" but currently we have them in main. we can always change it later.

@clarkliming clarkliming requested a review from BFalquet November 9, 2022 15:06
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Unit Tests Summary

  1 files    9 suites   22s ⏱️
27 tests 25 ✔️   2 💤 0
72 runs  51 ✔️ 21 💤 0

Results for commit a690f35.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thank you for the work. We could think of moving syn_test_data() to data-raw folder, save syn_data in an rds file and document it in data.R

path = c(medcat_var, "*", medname_var),
scorefun = score_occurrences
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@BFalquet BFalquet merged commit c523408 into main Nov 10, 2022
@BFalquet BFalquet deleted the 314_move_prune@main branch November 10, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move table sort/prune into post processing
2 participants