Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

301 chevron-rlistings-dependencies #302

Merged
merged 2 commits into from
Nov 1, 2022
Merged

301 chevron-rlistings-dependencies #302

merged 2 commits into from
Nov 1, 2022

Conversation

BFalquet
Copy link
Contributor

#301

close #301

@clarkliming
Copy link
Contributor

in description, do we have rlistings as well?

@arkadiuszbeer arkadiuszbeer self-requested a review October 31, 2022 12:33
@arkadiuszbeer
Copy link
Contributor

This also needs to be merged insightsengineering/rlistings#34

arkadiuszbeer
arkadiuszbeer approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@arkadiuszbeer arkadiuszbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    9 suites   1m 0s ⏱️
39 tests 37 ✔️   2 💤 0 ❌
90 runs  74 ✔️ 16 💤 0 ❌

Results for commit 2dddd03.

edelarua
edelarua approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@clarkliming
Copy link
Contributor

shall we also include the changes to the Remotes part of rlistings? it is not on cran yet

@cicdguy cicdguy merged commit 8c1a7ec into main Nov 1, 2022
@cicdguy cicdguy deleted the 301-chevron-rlistings-dependencies@main branch November 1, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

@arkadiuszbeer arkadiuszbeer arkadiuszbeer approved these changes

Assignees

@BFalquet BFalquet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chevron-rlistings-dependencies
5 participants
@BFalquet @clarkliming @arkadiuszbeer @edelarua @cicdguy