use scda.2022 #295
Merged
use scda.2022 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
nikolas-burkoff
commented
Oct 25, 2022
R/utils.R
Outdated
| @@ -89,7 +89,7 @@ get_db_data <- function(db, ...) { # TODO: revisit | |||
| #' Retrieve Synthetic Test Data Used For Examples | |||
| #' @export | |||
| syn_test_data <- function() { | |||
| sd <- scda::synthetic_cdisc_data("rcd_2021_03_22") | |||
| sd <- scda::synthetic_cdisc_data("rcd_2022_10_13") | |||
There was a problem hiding this comment.
@BFalquet I've changed this to use data from scda.2022 as scda.2021 is going to be archived
There was a problem hiding this comment.
ok so it looks like there are plenty of failures in the snapshot tests - I assume because the data has changed I think the core team will need some help making R CMD CHECK pass locally on this branch
There was a problem hiding this comment.
@clarkliming is updating the snapshots.
nikolas-burkoff
commented
Oct 25, 2022
Signed-off-by: Nikolas Burkoff <[email protected]>
BFalquet
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until the other scda PRs are ready
Part of insightsengineering/teal#760