Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

138 AET01 sample data review #230

Merged
merged 35 commits into from
Nov 7, 2022
Merged

138 AET01 sample data review #230

merged 35 commits into from
Nov 7, 2022

Conversation

BFalquet
Copy link
Contributor

close insightsengineering/chevron-tasks#54

  • update example to show how to create a custom column
  • modify default argument to fit better the snakemake philosophy
  • keep only SMQ01 and label it with SMQ01NAM label

thank you for the review

Meixh2021 and others added 27 commits June 1, 2022 13:36
@Meixh2021
For the breakdown of OTHER, the percentages are based on N.
350ee0a
@Meixh2021
For the breakdown of OTHER, the percentages are based on N.
c8da140
@BFalquet @Meixh2021
160 Replace asserthat with checkmate (#188)
e7715f4 
* remove assertthat and global variables

* styler and dep

Co-authored-by: benoit <[email protected]>
@crazycatandy @Meixh2021
[skip actions] Bump version to 0.1.0.9011
d70d353
@BFalquet @Meixh2021
modify subtitle (#192)
5cfb9f5 
Co-authored-by: benoit <[email protected]>
@crazycatandy @Meixh2021
[skip actions] Bump version to 0.1.0.9012
4c2c896
@BFalquet @Meixh2021
suppress notes (#191)
00c0cff 
Co-authored-by: benoit <[email protected]>
@BFalquet @Meixh2021
[skip actions] Bump version to 0.1.0.9013
f95fc3b
@BFalquet @Meixh2021
193 combine filter and mutate preprocessing function (#194)
1dfcf1f 
* add pre functions

* update pkgdown

* update doc

* add missing topic

Co-authored-by: benoit <[email protected]>
@wangh107 @Meixh2021
[skip actions] Bump version to 0.1.0.9014
365b3ad
@Meixh2021
#128 AET02 template issue
0550748
@Meixh2021
#128 AET02 template issue
359f0a6
@Meixh2021
#128 AET02 template issues
dedac77
@Meixh2021
#128 AET02 template issue
0580f88
@Meixh2021
#128 AET02 template issue
d4ff115
@Meixh2021
Force the table label on the topleft
d14d776
@Meixh2021
Update Main
67937fb 
Merge remote-tracking branch 'origin/main' into main

# Conflicts:
#	DESCRIPTION
#	NAMESPACE
#	NEWS.md
#	R/aet01.R
#	R/aet02.R
#	R/aet03.R
#	R/aet04.R
#	R/cmt01a.R
#	R/cmt02_pt.R
#	R/dm_explicit_na.R
#	R/dmt01.R
#	R/dst01.R
#	R/dtht01.R
#	R/egt01.R
#	R/egt02.R
#	R/ext01.R
#	R/lbt01.R
#	R/mht01.R
#	R/package.R
#	R/standard_data_preprocessing.R
#	R/utils.R
#	R/vst01.R
#	R/vst02.R
#	_pkgdown.yaml
#	man/aet01_1_main.Rd
#	man/aet01_2_main.Rd
#	man/aet02_1_main.Rd
#	man/aet02_2_main.Rd
#	man/aet02_3_main.Rd
#	man/aet03_1_main.Rd
#	man/aet04_1_main.Rd
#	man/cmt01a_2_main.Rd
#	man/cmt02_pt_1_main.Rd
#	man/dmt01_1_main.Rd
#	man/dst01_1_main.Rd
#	man/dst01_2_main.Rd
#	man/dst01_3_main.Rd
#	man/dtht01_1_main.Rd
#	man/egt01_1_main.Rd
#	man/egt02_1_main.Rd
#	man/egt02_2_main.Rd
#	man/ext01_1_main.Rd
#	man/ext01_2_main.Rd
#	man/lbt01_1_main.Rd
#	man/mht01_1_main.Rd
#	man/vst01_1_main.Rd
#	man/vst02_1_main.Rd
#	man/vst02_2_main.Rd
@Meixh2021
Update Main
7773a4e
@Meixh2021
update main
e217da0 
Merge branch 'temp' into 138_AET01_Template

# Conflicts:
#	NEWS.md
@Meixh2021
Update Main
39c48db
@Meixh2021
Update dtht01.R
818810b
@Meixh2021
Update Main
c847884
@Meixh2021
Update Main
78eae3c
@Meixh2021
Merge branch 'main' into 138_AET01_Template
83da423
Merge branch 'main' into 138_AET01_Template
d7e3aee
tim's suggestions
c93881a
impute labels
9c80b46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/aet01.R                      302     302  0.00%    32-565
R/aet02.R                      197     197  0.00%    26-433
R/aet03.R                       66      66  0.00%    28-134
R/aet04.R                       86      86  0.00%    29-158
R/assertions.R                  42      42  0.00%    21-104
R/checks.R                      14      14  0.00%    15-48
R/chevron_tlg-S4class.R         19      19  0.00%    37-90
R/chevron_tlg-S4methods.R       14      14  0.00%    15-117
R/cmt01a.R                     156     156  0.00%    35-405
R/cmt02_pt.R                    37      37  0.00%    23-90
R/dmt01.R                       29      29  0.00%    44-125
R/dst01.R                      231     231  0.00%    5-619
R/dtht01.R                      77      77  0.00%    27-163
R/egt01.R                       44      44  0.00%    35-123
R/egt02.R                       56      56  0.00%    28-189
R/ext01.R                       69      69  0.00%    30-237
R/gen_args.R                     1       1  0.00%    19
R/lbt01.R                       39      39  0.00%    33-114
R/mht01.R                       57      57  0.00%    30-122
R/sample_study_object.R         14      14  0.00%    14-35
R/utils.R                      106     106  0.00%    11-209
R/vst01.R                       45      45  0.00%    35-126
R/vst02.R                       92      92  0.00%    28-225
TOTAL                         1793    1793  0.00%

Results for commit: 83b58fe64755551e4dfb978dcf0791c104eb8ff0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@BFalquet BFalquet requested a review from barnett11 September 1, 2022 16:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited
Loading

Unit Tests Summary

  1 files  10 suites   49s ⏱️
40 tests 38 ✔️   2 💤 0 ❌
92 runs  74 ✔️ 18 💤 0 ❌

Results for commit ef396be.

♻️ This comment has been updated with latest results.

barnett11
barnett11 reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any control on the display of the variables from adsl?
image

@BFalquet
Copy link
Contributor Author

Do we have any control on the display of the variables from adsl? image

For now it is fixed, which kind of control would you like ? Replacing Patients by Subject for instance?

@BFalquet BFalquet marked this pull request as draft October 25, 2022 13:01
@BFalquet BFalquet requested a review from barnett11 October 25, 2022 14:00
@BFalquet BFalquet marked this pull request as ready for review October 25, 2022 14:00
barnett11
barnett11 previously requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should not to have pooled trt group @BFalquet

@barnett11 barnett11 self-requested a review November 3, 2022 08:35
@barnett11
Copy link
Contributor

Default should not to have pooled trt group @BFalquet

My mistake, this is fine

@barnett11 barnett11 dismissed their stale review November 3, 2022 08:36

Mistaken

barnett11
barnett11 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thank you @BFalquet - enhancement for aet01_2 added in separate issue, but for now we can finalise this version

@BFalquet BFalquet merged commit 10ad03a into main Nov 7, 2022
@BFalquet BFalquet deleted the 138_AET01_Template branch November 7, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnett11 barnett11 barnett11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BFalquet @barnett11 @Meixh2021 @crazycatandy @wangh107