-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
128 aet02 template #204
128 aet02 template #204
Conversation
* remove assertthat and global variables * styler and dep Co-authored-by: benoit <[email protected]>
Co-authored-by: benoit <[email protected]>
Co-authored-by: benoit <[email protected]>
* add pre functions * update pkgdown * update doc * add missing topic Co-authored-by: benoit <[email protected]>
Code Coverage Summary
Results for commit: b52fd42c9c2697357d23d4fae236d7bd4e6c8d75 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Thanks @Meixh2021 Tim @barnett11 , what do you think if we include the following steps in the corresponding preprocess functions
|
Yes that should do it thanks @wangh107 |
@wangh107 @barnett11 for item 2, currently the label of output is based on the label of the data. My question is shall we force the labels? For example, do all outputs generated by |
Yes, we should use the template-defined column name regardless of the CDISC attributed label thanks |
Another question for Tim @barnett11 |
There is no specific guidance @Meixh2021 , but the general practice of just including in the frequency list is sufficient thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the good work. Please see my comments inside.
you can have a look at insightsengineering/tern#577 if that helps for dtht01.
cheers
Co-authored-by: b_falquet <[email protected]>
Co-authored-by: b_falquet <[email protected]>
Co-authored-by: b_falquet <[email protected]>
Co-authored-by: b_falquet <[email protected]>
Co-authored-by: b_falquet <[email protected]>
Thanks @BFalquet, now I believe that this pull request can also help solve some issues in insightsengineering/chevron-tasks#47. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Meixh2021
Suggest to include a data process in aet02_x_pre
to code missing in AEBODSYS, AEHLT, AEDECOD
as "No Coding Available" (only do it in the 3 mentioned variables in adae
dataset, not the whole dm
object.)
@barnett11 Hi Tim, if you are available, would you please review the current template can meet the TLG criteria? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thank you for the work. Beware that important changes are coming to chevron soon.
Thanks @Meixh2021 |
close insightsengineering/chevron-tasks#42
Hi @wangh107 @barnett11, thanks to the @BFalquet, I believed the current version of
chevron
can help sort theAEBODSYS
correctly.For the
No Coding Available
, I just added additionaldm_explicit_na(na_level = "No Coding available")
to fix that issue.I corrected a sorting problem when the argument
lbl_overall = NULL
, the sorting will be based on the last column but not the whole column inaet02_1()
.You might check the issue again with the following codes:
Thanks!