Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements after overall code review #162

Merged
merged 4 commits into from
Mar 29, 2022
Merged

enhancements after overall code review #162

merged 4 commits into from
Mar 29, 2022

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Mar 28, 2022

  • remove append_to_pmap
  • remove std_preprocessing_map copy of already existing std_pmap
  • consolidate importFrom tags
  • clean-up examples not to call unnecessary libraries
  • remove empty return roxgen
  • rename introduction vignette so that it appears as the "package introduction" in the pkgdown website
  • few prefixes
  • lint/formatting

@pawelru pawelru requested review from wangh107 and BFalquet March 28, 2022 10:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/aet01.R                            138     138  0.00%    38-320
R/aet02.R                            163     163  0.00%    53-413
R/aet03.R                             61      61  0.00%    41-142
R/aet04.R                             81      81  0.00%    46-164
R/assertions.R                        23      23  0.00%    21-46
R/assertthat.R                         1       1  0.00%    3
R/cmt01a.R                           132     132  0.00%    50-370
R/cmt02_pt.R                          29      29  0.00%    34-90
R/dm_explicit_na.R                    44      44  0.00%    47-125
R/dmt01.R                             20      20  0.00%    44-108
R/dst01.R                            212     212  0.00%    5-549
R/dtht01.R                            69      69  0.00%    46-177
R/egt01.R                             39      39  0.00%    45-121
R/egt02.R                             44      44  0.00%    42-190
R/ext01.R                             41      41  0.00%    39-174
R/gen_args.R                           1       1  0.00%    18
R/lbt01.R                             34      34  0.00%    43-111
R/mht01.R                             52      52  0.00%    39-123
R/sample_study_object.R               14      14  0.00%    14-35
R/standard_data_preprocessing.R      218     218  0.00%    52-505
R/utils.R                            137     137  0.00%    16-374
R/vst01.R                             40      40  0.00%    46-124
R/vst02.R                             44      44  0.00%    42-189
TOTAL                               1637    1637  0.00%

Results for commit: afe0408f247cf81b4f8b078d20b51ceb34b4c8cd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@wangh107 wangh107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for enhancement!

@pawelru pawelru merged commit 852233d into main Mar 29, 2022
@pawelru pawelru deleted the pr_enhancements branch March 29, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants