Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

141 mth01 faulty preprocessing #142

Merged
merged 1 commit into from
Feb 15, 2022
Merged

141 mth01 faulty preprocessing #142

merged 1 commit into from
Feb 15, 2022

Conversation

BFalquet
Copy link
Contributor

close #141

correct preprocessing

@BFalquet BFalquet added the bug Something isn't working label Feb 15, 2022
@BFalquet BFalquet requested a review from barnett11 February 15, 2022 13:00
@github-actions
Copy link
Contributor

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/aet01.R                            142     142  0.00%    42-330
R/aet02.R                            163     163  0.00%    55-418
R/aet03.R                             61      61  0.00%    44-145
R/aet04.R                             67      67  0.00%    53-159
R/assertions.R                        23      23  0.00%    23-48
R/assertthat.R                         1       1  0.00%    3
R/cmt01a.R                           132     132  0.00%    53-379
R/cmt02_pt.R                          29      29  0.00%    38-95
R/dm_explicit_na.R                    44      44  0.00%    46-133
R/dmt01.R                             20      20  0.00%    48-113
R/dst01.R                            203     203  0.00%    5-542
R/egt01.R                             39      39  0.00%    47-126
R/ext01.R                             41      41  0.00%    40-176
R/gen_args.R                           1       1  0.00%    18
R/lbt01.R                             34      34  0.00%    43-111
R/mht01.R                             52      52  0.00%    42-126
R/sample_study_object.R               12      12  0.00%    15-34
R/standard_data_preprocessing.R      170     170  0.00%    38-459
R/utils.R                            130     130  0.00%    17-373
R/vst01.R                             40      40  0.00%    48-128
TOTAL                               1404    1404  0.00%

Results for commit: 2e735f2b6229aa0bc36daed7ee2612b9e32b7458

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

barnett11
barnett11 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect thanks @BFalquet

@BFalquet BFalquet merged commit 405dec2 into main Feb 15, 2022
@BFalquet BFalquet deleted the 141_mth01-faulty-preprocessing@main branch February 15, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnett11 barnett11 barnett11 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mth01 faulty preprocessing
2 participants
@BFalquet @barnett11