-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
130 DST01 sample data review #131
Conversation
Code Coverage Summary
Results for commit: 7d8b91300db3123ecd75f39609aa7c5183b6f2e4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further feedback added to #130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good thanks @BFalquet
Two outstanding issues on alignment and 0% can be looked at later/resolved in rtables hopefully
close insightsengineering/chevron-tasks#43
implement suggested changes (except the null digit problem which is an rtables problem)
thank you for the review