Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23 CMT02_PT #118

Merged
merged 9 commits into from
Feb 2, 2022
Merged

23 CMT02_PT #118

merged 9 commits into from
Feb 2, 2022

Conversation

BFalquet
Copy link
Contributor

close insightsengineering/chevron-tasks#16

cmt02_pt table, please have a look at the indentation.
thank you for the review.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022 •
edited
Loading

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/aet01.R                            112     112  0.00%    41-286
R/aet02.R                            163     163  0.00%    55-418
R/aet03.R                             61      61  0.00%    44-145
R/aet04.R                             67      67  0.00%    53-159
R/assertthat.R                         1       1  0.00%    3
R/cmt01a.R                           132     132  0.00%    53-379
R/cmt02_pt.R                          29      29  0.00%    38-95
R/dm_explicit_na.R                    44      44  0.00%    46-133
R/dmt01.R                             20      20  0.00%    48-113
R/dst01.R                            203     203  0.00%    5-542
R/egt01.R                             39      39  0.00%    47-126
R/ext01.R                             41      41  0.00%    40-176
R/gen_args.R                           1       1  0.00%    18
R/lbt01.R                             34      34  0.00%    43-111
R/mht01.R                             52      52  0.00%    42-126
R/sample_study_object.R               12      12  0.00%    15-34
R/standard_data_preprocessing.R      169     169  0.00%    38-458
R/utils.R                            139     139  0.00%    17-399
R/vst01.R                             40      40  0.00%    48-128
TOTAL                               1359    1359  0.00%

Results for commit: 27cd87f1468f372b0dda5c6cd35bf1b13de2a709

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@wangh107 wangh107 self-requested a review January 25, 2022 16:27
@BFalquet BFalquet marked this pull request as ready for review January 25, 2022 16:29
wangh107
wangh107 reviewed Jan 27, 2022
View reviewed changes
Copy link
Contributor

@wangh107 wangh107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update filter_adcm_concomitant to filter by ANL01FL == "Y" instead of SAFFL == "Y"

@BFalquet
Copy link
Contributor Author

please update filter_adcm_concomitant to filter by ANL01FL == "Y" instead of SAFFL == "Y"

Thnak you for the rewiew, the filter has been updated. cmt02_pt and cmt01 now use the same filter which uses ANL01FL == "Y"

barnett11
barnett11 requested changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BFalquet , suggestions attached

@BFalquet BFalquet requested a review from barnett11 January 28, 2022 20:41
wangh107
wangh107 reviewed Jan 31, 2022
View reviewed changes
barnett11
barnett11 requested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BFalquet

@BFalquet BFalquet requested a review from barnett11 February 2, 2022 15:39
@BFalquet BFalquet merged commit 694e467 into main Feb 2, 2022
@BFalquet BFalquet deleted the 23_cmt02_pt@main branch February 2, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangh107 wangh107 wangh107 left review comments

@barnett11 barnett11 barnett11 approved these changes

Assignees
No one assigned
Labels
Tier 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BFalquet @wangh107 @barnett11