Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cards switch from staged-dependencies to setup-r-dependencies for deps install #350

Closed
Tracked by #65
shajoezhu opened this issue Oct 25, 2024 · 0 comments · Fixed by #351
Closed
Tracked by #65

cards switch from staged-dependencies to setup-r-dependencies for deps install #350

shajoezhu opened this issue Oct 25, 2024 · 0 comments · Fixed by #351
Assignees
@shajoezhu
Labels
sme

Comments

@shajoezhu
Copy link
Contributor

shajoezhu commented Oct 25, 2024 •
edited
Loading

TODO:

  1. edit .github/worflows/check.yaml
    1.1 adding line deps-installation-method: setup-r-dependencies under with: below these jobs,

    • roxygen
    • coverage
    • r-cmd-non-cran
    • r-cmd

    1.2 below deps-installation-method: setup-r-dependencies add its option if applicable (i.e. staged_dependencies.yaml has upstream entriex), e.g. for tern, it has upsteam rtables, formatters, and nestcolor

        insightsengineering/nestcolor
        insightsengineering/rtables
        insightsengineering/formatters

make sure lookup-refs has the same indentation as deps-installation-method

  1. rm staged_dependencies.yaml

see this PR for example https://github.com/insightsengineering/formatters/pull/325/files
@shajoezhu shajoezhu mentioned this issue Oct 25, 2024
Closed
38 tasks
@shajoezhu shajoezhu added the sme label Oct 25, 2024
@shajoezhu shajoezhu transferred this issue from insightsengineering/nestdevs-tasks Oct 25, 2024
@shajoezhu shajoezhu changed the title cards cards switch from staged-dependencies to setup-r-dependencies for deps install Oct 29, 2024
shajoezhu added a commit that referenced this issue Oct 29, 2024
@shajoezhu
Update check.yaml
25a3331 
close #350 

Signed-off-by: Joe Zhu <[email protected]>
@shajoezhu shajoezhu mentioned this issue Oct 29, 2024
Merged
12 tasks
shajoezhu added a commit that referenced this issue Oct 30, 2024
@shajoezhu
Update check.yaml (#351)
fc9ebf4 
close #350

**What changes are proposed in this pull request?**
* Style this entry in a way that can be copied directly into `NEWS.md`.
(#<issue number>, @<username>)

Provide more detail here as needed.

**Reference GitHub issue associated with pull request.** _e.g., 'closes
#<issue number>'_



--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [ ] If a bug was fixed, a unit test was added.
- [ ] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [ ] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [ ] If a bug was fixed, a unit test was added.
- [ ] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [ ] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [ ] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Signed-off-by: Joe Zhu <[email protected]>
@shajoezhu shajoezhu self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update check.yaml insightsengineering/cards
1 participant
@shajoezhu