save_qgis.py: Use single context manager for 4 files

[scottstanie]

Description of proposed changes

No need for the quadruple nesting in opening the 4 HDF5 files.
No other change made besides the with nesting depth.

Reminders

• Fix #xxxx
• Pass Pre-commit check (green)
• Pass Codacy code review (green)
• Pass Circle CI test (green)
• Make sure that your code follows our style. Use the other functions/files as a basis.
• If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

Summary by Sourcery

Enhancements:

• Simplify file handling in save_qgis.py by using a single context manager for opening four HDF5 files.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR refactors the write_shape_file function in save_qgis.py to use a single context manager for opening four HDF5 files, simplifying the code and improving readability.

Sequence diagram for file handling in write_shape_file

sequenceDiagram
    participant F as write_shape_file
    participant H as HDF5 Files
    Note over F, H: Before: Nested context managers
    F->>H: Open TimeSeries file
    activate H
    F->>H: Open Coherence file
    F->>H: Open Velocity file
    F->>H: Open Geometry file
    F->>H: Process data
    H-->>F: Close all files
    deactivate H
    Note over F, H: After: Single context manager
    F->>H: Open all files simultaneously
    activate H
    F->>H: Process data
    H-->>F: Close all files
    deactivate H

Loading

Flow diagram showing file handling improvement

flowchart LR
    subgraph Before
    A[Start] --> B[Open TimeSeries]
    B --> C[Open Coherence]
    C --> D[Open Velocity]
    D --> E[Open Geometry]
    E --> F[Process Data]
    F --> G[Close Files]
    G --> H[End]
    end
    subgraph After
    I[Start] --> J[Open All Files]
    J --> K[Process Data]
    K --> L[Close Files]
    L --> M[End]
    end

Loading

File-Level Changes

Change	Details	Files
Uses a single context manager with the with statement to open four HDF5 files simultaneously.	Replaces nested with statements for each file with a single with statement that opens all four files at once. Removes the individual close statements for each file as they are now handled implicitly by the single context manager.	src/mintpy/save_qgis.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codeautopilot]

PR summary

This Pull Request refactors the write_shape_file function in src/mintpy/save_qgis.py by consolidating the opening of four HDF5 files into a single context manager. This change simplifies the code by reducing the nesting depth, making it more readable and maintainable. The functionality of the code remains unchanged, as the refactor only affects how the files are opened and managed within the context manager.

Review Checklist

• Fix #xxxx: Not applicable, as no issue number is provided.
• Pass Pre-commit check (green): Ensure pre-commit checks are passing.
• Pass Codacy code review (green): Verify Codacy review is successful.
• Pass Circle CI test (green): Confirm Circle CI tests are passing.
• Make sure that your code follows our style. Use the other functions/files as a basis: The refactor aligns with the existing code style.
• If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration: Not applicable, as functionality is not modified.
• If adding new functionality, add a detailed description to the documentation and/or an example: Not applicable, as no new functionality is added.

Suggestion

Consider adding a test case to ensure that the refactored context manager behaves as expected, especially if there are any edge cases related to file handling that should be verified.

This comment was generated by AI. Information provided may be incorrect.

Current plan usage: 0%

Have feedback or need help?
Documentation
[email protected]

[sourcery-ai]

Hey @scottstanie - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[yunjunz]

LGTM. Thank you @scottstanie!