-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/dir_structure: add iono example for topsStack & alosStack #1275
Conversation
+ docs/dir_structure: - add example file directory structure and corresponding template input file patterns for isce2/topsStack - add example template input file patterns for isce2/alosStack & isce2/stripmapStack + modify_network: ignore "," in the input --ex-date(12) options, as copied from the template file
Reviewer's Guide by SourceryThis pull request adds examples of file directory structure and template input file patterns for isce2/topsStack and isce2/alosStack, as well as modifies the Class diagram for modify_network function changesclassDiagram
class ModifyNetwork {
- excludeDate: List<String>
- excludeDate12: List<String>
+ cmd_line_parse(iargs=None)
}
ModifyNetwork : +cmd_line_parse(iargs=None)
ModifyNetwork : +excludeDate = [x.replace(',', '') for x in excludeDate]
ModifyNetwork : +excludeDate12 = [x.replace(',', '') for x in excludeDate12]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR summaryThis Pull Request updates the documentation to include example directory structures and template input file patterns for SuggestionConsider adding unit tests for the Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect. Current plan usage: 0.00% Have feedback or need help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yunjunz - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes in view.py from vprint() to print() might affect verbosity control. Please review if this change is intentional and consider its potential impact on the program's behavior.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description of proposed changes
docs/dir_structure:
modify_network: ignore "," in the input --ex-date(12) options, as copied from the template file
Reminders
Summary by Sourcery
Update documentation with examples for isce2/topsStack and isce2/alosStack, fix comma handling in modify_network script, and enhance logging in view.py.
Bug Fixes:
Enhancements:
Documentation: